{{ message }}
Repository navigation
[rc/3.23] Java: isolate Maven integration test repositories - #22855
Merged
Merged
Conversation
Backport of 7bd102b to rc/3.23. Maven 3.10 writes resolver-status.properties into the local repository. Keep generated repository state outside the test source root so source archive expectations remain stable across Maven versions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow, test-only changes isolate Maven state without altering existing settings selection, and no blocking issues were identified.
No open issues 🎉
What changed in this PR
Backports Maven integration-test repository isolation to rc/3.23, keeping resolver metadata out of source archives.
Changes:
- Place Maven local repositories under pytest’s
tmp_path. - Preserve existing fake-home and Maven settings configurations.
Review effort: Max
cklin
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of 7bd102b (already on main) to rc/3.23.
Newer Maven on the macOS runners writes
resolver-status.propertiesinto the local repository under the test's fake home (empty-home/.m2/repository/.meta/), which is inside the source root and so ends up insource_archive.actual. This makesbuildless-maven,buildless-maven-mirrorofandbuildless-maven-existing-settings-xmlfail. Setting-Dmaven.repo.localto a temp dir keeps that state out of the source archive.