{{ message }}
Repository navigation
Conversation
Co-authored-by: asgerf <316427+asgerf@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix StorageEvent constructor to accept arguments
Align JavaScript StorageEvent externs with current Web IDL
Oct 20, 2026
asgerf
marked this pull request as ready for review
October 21, 2026 08:19
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused declarations and regression cases match the intended API, with no blocking correctness issues identified.
1 open issue
What changed in this PR
Updates JavaScript browser externs to match modern StorageEvent signatures and prevent false positives.
Changes:
- Add the constructor’s required type and optional event dictionary.
- Correct initializer optionality and key nullability.
- Cover valid constructor calls and excess arguments.
Review effort: Max
Contributor
Author
There was a problem hiding this comment.
Added the requested minorAnalysis change note in commit 55dc32272c0.
Co-authored-by: asgerf <316427+asgerf@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The zero-argument
StorageEventmodel causes false positives on valid browser constructor calls. Its legacy initializer also incorrectly marks optional parameters as required.typeand accept an optionalStorageEventInitdictionary with inherited event options.typeoptional and correctkeynullability.