Allow CODEOWNERS file detection to see into the .github directory by zkoppert · Pull Request #181 · github/.github · GitHub
Skip to content

Allow CODEOWNERS file detection to see into the .github directory#181

Merged
ashleywolf merged 1 commit into
github:masterfrom
zkoppert:patch-2
May 2, 2022
Merged

Allow CODEOWNERS file detection to see into the .github directory#181
ashleywolf merged 1 commit into
github:masterfrom
zkoppert:patch-2

Conversation

@zkoppert

@zkoppert zkoppert commented May 2, 2022

Copy link
Copy Markdown
Member

*/CODEOWNERS was not matching directories beginning with . such as .github/CODEOWNERS.

This should solve the issue we saw in this run where CODEOWNERS was present but not detected.

ashleywolf
ashleywolf approved these changes May 2, 2022
View reviewed changes

@ashleywolf ashleywolf left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you for fixing this

@Mikkuueda

Mikkuueda commented May 2, 2022 via email

Copy link
Copy Markdown

@Mikkuueda

Mikkuueda commented May 2, 2022 via email

Copy link
Copy Markdown

@ashleywolf ashleywolf merged commit 45190ea into github:master May 2, 2022
@zkoppert zkoppert deleted the patch-2 branch May 2, 2022 18:22
@ahmedrem55538

ahmedrem55538 commented May 13, 2022

Copy link
Copy Markdown

me me. I'm not that think who feel nothing I saw you and your behind they real now you belive. no lies
…
On Mon, 2 May 2022, 21:09 Zack Koppert, @.*> wrote: /CODEOWNERS was not matching directories beginning with . such as .github/CODEOWNERS. This should solve the issue we saw in this run https://github.com/github/open-source-releases/issues/247#issuecomment-1115180957 where CODEOWNERS was present but not detected. ------------------------------ You can view, comment on, or merge this pull request online at: #181 Commit Summary - 3ba05a7 <3ba05a7> * was not matching directories beginning with . File Changes (1 file https://github.com/github/.github/pull/181/files) - M config/repolinter-ruleset.json https://github.com/github/.github/pull/181/files#diff-fb350faa94dcd8c44303d2709929c4a16ca52c35d61ad9d810f60f6206dcfe8c (2) Patch Links: - https://github.com/github/.github/pull/181.patch - https://github.com/github/.github/pull/181.diff — Reply to this email directly, view it on GitHub <#181>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYMUDN6PN4Z77EG7UTDMPLLVIAK6LANCNFSM5U4V4P6A . You are receiving this because you are subscribed to this thread.Message ID: @.>

Ahmed rem55538

@ahmedrem55538

ahmedrem55538 commented May 13, 2022

Copy link
Copy Markdown

Ahmed rem55538

  • [ ]ربط الايميل ###

ahmedrem55538
ahmedrem55538 reviewed May 13, 2022
View reviewed changes

@ahmedrem55538 ahmedrem55538 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahmed.rem55538@gmail.com google.com

Zolitoi
Zolitoi reviewed Jul 5, 2024
View reviewed changes

@Zolitoi Zolitoi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zolitoi

Zolitoi
Zolitoi suggested changes Jul 5, 2024
View reviewed changes

@Zolitoi Zolitoi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

******в_Backup-codes-andrijgynchik.txt

******_

@Zolitoi

Zolitoi commented Jul 5, 2024

Copy link
Copy Markdown

__

@Zolitoi

Zolitoi commented Jul 5, 2024

Copy link
Copy Markdown

Zolitoi
Zolitoi reviewed Jul 5, 2024
View reviewed changes

@Zolitoi Zolitoi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zolitoi

roberthmacedo094-jpg referenced this pull request Oct 19, 2025
@zkoppert
Merge pull request #483 from josiahaltschuler/capitalize-the-word-git
094daac 
Capitalize the word git
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashleywolf ashleywolf ashleywolf approved these changes
+2 more reviewers
@ahmedrem55538 ahmedrem55538 ahmedrem55538 left review comments
@Zolitoi Zolitoi Zolitoi requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@zkoppert @Mikkuueda @ahmedrem55538 @Zolitoi @ashleywolf @MAGDALENAPLROMANOWSKA @Jesslc241291capricornio @0922640331 @As098709