sort username for issue comments#1964
Conversation
There was a problem hiding this comment.
context.loginAccount.contains(a.userName) is much simpler.
There was a problem hiding this comment.
Getting repository and issue (or pull request) identifier from referrer is nice idea, but I think it's little tricky. It might be better to pass these information as optional query string parameters.
There was a problem hiding this comment.
As I know, this request is called from helper/attached.scala.html through helper/preview.scala.html. preview.scala.html called from issue/pulls comment, wiki edit and release message edit. So it is complicated to add optional query string.
There was a problem hiding this comment.
Ah... Okay. It wasn't so easy. Anyway, I don't prefer kind of ad-hoc solution. I will try to find an another way. Sorry for keeping this pull request reviewing.
2 participants
Sort usernames for useful order.
Before submitting a pull-request to GitBucket I have first: