{{ message }}
Repository navigation
Update Windows release signing action - #6222
Merged
chrisd8088 merged 3 commits intoMar 31, 2026
Merged
Conversation
The name of the "azure/trusted-signing-action" GitHub repository was recently changed to "azure/artifact-signing-action" in PR Azure/artifact-signing-action#108, so we update our GitHub Actions release workflow to use the new name in our "build-windows" job, as the job would otherwise fail. We also rename one of the input parameters we pass to the Action, as the same PR Azure/artifact-signing-action#108 deprecated the parameter name "trusted-signing-account-name" in favour of the simpler term "signing-account-name". Finally, we update the value of the "endpoint" input parameter we pass to the Action, as our Windows Artifact Signing account and certificate profile have apparently moved to a new Azure region. h/t divz44 and padraignix for their help diagnosing the region change
chrisd8088
added
windows
github_actions
larsxschneider
approved these changes
Mar 30, 2026
In a prior commit in this PR we updated the value of the "endpoint" input parameter we pass to the "azure/artifact-signing-action" Action in the "build-windows" job of our GitHub Actions release workflow, because our Windows Artifact Signing account and certificate profile have apparently moved to a new Azure region. As suggested by larsxschneider on PR review, we now also add comments which describe the requirement that the "endpoint" parameter's value match the Azure region where our account and profile reside.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The name of the
azure/trusted-signing-actionGitHub repository was recently changed toazure/artifact-signing-actionin PR Azure/artifact-signing-action#108, so we update our GitHub Actions release workflow to use the new name in ourbuild-windowsjob, as the job would otherwise fail.We also rename one of the input parameters we pass to the Action, as the same PR Azure/artifact-signing-action#108 deprecated the parameter name
trusted-signing-account-namein favour of the simpler termsigning-account-name.Finally, we update the value of the
endpointinput parameter we pass to the Action, as our Windows Artifact Signing account and certificate profile have apparently moved to a new Azure region.Note that this PR's changes were tested successfully in a private repository.
Many thanks to @divz44 and @padraignix for their help diagnosing the region change!