{{ message }}
Repository navigation
workflows: use ronn-ng - #4992
Merged
Merged
Conversation
Recently, we changed to use the windows-2019 target because ronn fails to build on newer versions. Unfortunately, it also fails to build on that version due to updates in GitHub Actions. Since ronn itself is dead upstream, let's switch to ronn-ng, just like Debian has done. This provides an identically named binary but is a supported codebase that is more likely to work now and in the future.
Member
bk2204
marked this pull request as ready for review
May 5, 2022 15:53
chrisd8088
approved these changes
May 5, 2022
chrisd8088
left a comment
chrisd8088
left a comment
Member
There was a problem hiding this comment.
LGTM. I wonder if it will require ruby/setup-ruby@v1 on the Windows 2022 runners or if it will work with the older, deprecated actions/setup-ruby@v1 we're using now. The latter would mean we could probably switch to the windows-latest runners again, per #4883. If we need ruby/setup-ruby@v1, though, we may still run into problems, IIRC.
Regardless, though, this is definitely a strict improvement over the status quo.
Member
Author
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
May 7, 2022
In commit f4ab4e7 of PR git-lfs#4883 we noted that the "gem install ronn" step in our Windows CI workflows currently fails on newer Windows Server 2022 GitHub Actions runners, due to possibly some missing C headers or libraries. While this could be resolved by upgrading to the "ruby/setup-ruby" action from the deprecated "actions/setup-ruby" one, that introduced a series of issues with PATH lookups as documented in ruby/setup-ruby#293. We therefore chose to continue using Windows 2019 runners until a resolution or workaround was found. Fortunately, as of commit 912b607 in PR git-lfs#4992 we are now using the ronn-ng Ruby gem instead of the unmaintained ronn gem, and the "gem install ronn-ng" workflow step succeeds on Windows 2022 while still using the "actions/setup-ruby" action to install a Ruby build environment. This allows us to upgrade to the latest Windows runners in GitHub Actions, although we can't yet upgrade to the "ruby/setup-ruby" workflow action. h/t to @bk2204 for finding ronn-ng!
This was referenced May 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, we changed to use the windows-2019 target because ronn fails to build on newer versions. Unfortunately, it also fails to build on that version due to updates in GitHub Actions.
Since ronn itself is dead upstream, let's switch to ronn-ng, just like Debian has done. This provides an identically named binary but is a supported codebase that is more likely to work now and in the future.