{{ message }}
This repository was archived by the owner on Sep 3, 2025. It is now read-only.
Minor refactoring around the build/test infrastructure#8
Merged
Conversation
Update 'actions/checkout' version from 2 to 3 to address the Node 12 deprecation warning. Signed-off-by: Victoria Dye <vdye@github.com>
The 'git-bundle-server' repository is checked out to 'src/git-bundle-server' in anticipation of future dependencies (e.g., Git) being checked out to parallel 'src' directories for use in integration tests. The initial implementation of this workflow included explicit specification of the 'GOPATH' for both 'go build' and 'go vet'; this is not necessary, so remove it. Additionally, add a note about how the upcoming '-C' option should remove the need for an explicit '-C' in each build step. Signed-off-by: Victoria Dye <vdye@github.com>
The Go project recommends single-module repositories over multi-module wherever possible [1]; multi-module setups seem to be most useful when they represent separately-versioned and released projects living within the same repository (further analysis in [2]). Additionally, there is currently no convenient way to test all modules in a 'go.work' file (see [3]). Due to the factors listed, convert repository from multi- to single-module. [1] https://github.com/golang/go/wiki/Modules#should-i-have-multiple-modules-in-a-single-repository [2] https://medium.com/compass-true-north/catching-up-with-the-world-go-modules-in-a-monorepo-c3d1393d6024 [3] golang/go#50745 Signed-off-by: Victoria Dye <vdye@github.com>
Add step to unit test all packages in the repository. At the moment, no unit tests exist, so tests always pass. Signed-off-by: Victoria Dye <vdye@github.com>
ldennington
approved these changes
Jan 6, 2023
Collaborator
ldennington
left a comment
ldennington
left a comment
There was a problem hiding this comment.
This looks great and was super easy to review. The only small suggestion I have is linking to a successful workflow run with your changes.
Collaborator
There was a problem hiding this comment.
I'm unfamiliar with the ./... syntax, but I like how it cleans this up!
derrickstolee
approved these changes
Jan 6, 2023
Collaborator
derrickstolee
left a comment
derrickstolee
left a comment
There was a problem hiding this comment.
Thanks for cleaning up all these things with links to the Go standards that inform them.
Collaborator
There was a problem hiding this comment.
Interesting. I did not know that a single module could generate multiple executables. TIL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These commits help the repository better align with Go's project layout standards, add basic unit test execution to CI, and clean up some miscellaneous warnings.
The changes in this PR don't do much on their own, but merging them ahead of new feature development (e.g.
git-bundle-server web-server) helps avoid mixing overarching infrastructure changes with feature-specific implementation/testing in future PRs.