Task/improve language localization for NL by munzzyy · Pull Request #7296 · ghostfolio/ghostfolio · GitHub
Skip to content

Task/improve language localization for NL - #7296

Merged
dtslvr merged 3 commits into
ghostfolio:mainfrom
munzzyy:task/improve-language-localization-for-nl-20260709
Jul 12, 2026
Merged

dtslvr merged 3 commits into
ghostfolio:mainfrom
munzzyy:task/improve-language-localization-for-nl-20260709

Conversation

@munzzyy

@munzzyy munzzyy commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Fills in the 14 entries in messages.nl.xlf that went to state="new" since #7260 merged (2026-07-07). These are new strings added by other PRs since then: Copy, Close Account, Net Worth Tracking, Tax Reporting, the security hint text on the close-account flow, and the Post to Ghostfolio on X share link.

3 of the 14 already had correct Dutch text but were still flagged new, the same drift #7260 ran into. The source's <x> interpolation picked up an i18n-title attribute that the target's copy never got, so the extractor kept treating an already-translated string as untranslated. Fixed those by matching the equiv-text back to source and flipping the state.

Kept to the terminology already in the file. Dividend Tracking translates to Dividend volgen and Stock Tracking to Aandelen volgen, so Net Worth Tracking follows the same pattern (Netto waarde volgen, with Netto waarde itself already used elsewhere). Same for Close Account, which the file already translates as Account Sluiten at a different call site for the identical button label.

@dtslvr dtslvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @munzzyy!

Comment thread apps/client/src/locales/messages.nl.xlf Outdated
@dtslvr
dtslvr force-pushed the task/improve-language-localization-for-nl-20260709 branch from a3892ac to 57e6239 Compare July 12, 2026 07:31

@dtslvr dtslvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, @munzzyy! 👍🏻

@dtslvr
dtslvr force-pushed the task/improve-language-localization-for-nl-20260709 branch from 57e6239 to 73ed664 Compare July 12, 2026 08:10
@dtslvr
dtslvr merged commit 59baec0 into ghostfolio:main Jul 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants