Fix #2033: [Bug] FalkorDB: get_by_group_ids returns empty for non-default groups by nandanadileep · Pull Request #2039 · getzep/graphiti · GitHub
Skip to content

Fix #2033: [Bug] FalkorDB: get_by_group_ids returns empty for non-default groups - #2039

Open
nandanadileep wants to merge 3 commits into
getzep:mainfrom
nandanadileep:agent/issue-2033-bug-falkordb-get-by-group-ids-
Open

nandanadileep wants to merge 3 commits into
getzep:mainfrom
nandanadileep:agent/issue-2033-bug-falkordb-get-by-group-ids-

Conversation

@nandanadileep

Copy link
Copy Markdown
Contributor

Fixes #2033

What changed

Fixed _make_adapter in graphiti_core/driver/falkordb/operations/graph_operations_interface.py to drop the unbound interface method's leading self parameter before binding caller arguments, correcting the one-position argument shift that caused EpisodicNode.get_by_group_ids (and other classmethods) to pass the group_ids list as the executor and fail with 'list' object has no attribute 'execute_query'.

Verification

python -m pytest -q -x --import-mode=importlib tests/driver/test_falkordb_driver.py tests/driver/test_falkordb_ops_routing.py passed

@github-actions github-actions Bot added bug Something isn't working scope:core labels Oct 19, 2026
@zep-cla-assistant

zep-cla-assistant Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor

AI-assisted source review of 92ddb3d; I have not executed these paths.

The newly wired facade appears to break the fallback contract for four existing hooks: remove_communities, node_get_by_names, saga_get_previous_episode_uuid, and saga_get_episode_contents. They are absent from _METHOD_MAP, so __getattr__ raises AttributeError, whereas their callers catch only NotImplementedError.

The effects are specific:

  • remove_communities cannot reach its existing graph_ops fallback, so Graphiti.build_communities fails during its initial clearing step.
  • The two saga hooks raise instead of running the previous-episode query or returning None to let summarization use its query fallback.
  • EntityNode.get_by_names raises instead of reaching its query fallback. Its ingestion caller catches that error and falls back to semantic search, losing the exact-name candidates.

Could unsupported hooks preserve the NotImplementedError contract, or receive explicit delegation? Facade-backed caller regressions should assert the fallback delegate/query is actually reached and its results are preserved, including the saga None sentinel and the subsequent summarization query. That would exercise more than facade construction and the one episodic routing call currently added.

Please also select the existing tests/driver/test_falkordb_ops_routing.py module in CI: unit_tests.yml excludes tests/driver/ from the no-database job, while the database job names only test_falkordb_driver.py from that directory. Neither selection includes the two appended regressions.

Preserve caller fallbacks for remove_communities, node_get_by_names, and
the saga hooks. Fix ruff import order/format and collect the routing
regressions in the no-database CI job.

Co-authored-by: Nandana Dileep <nandanadileep@users.noreply.github.com>
Assert remove_communities, node_get_by_names, and the saga hooks still
reach graph_ops and Cypher fallbacks, including the None sentinel that
triggers summarization's query path.

Co-authored-by: Nandana Dileep <nandanadileep@users.noreply.github.com>

Copy link
Copy Markdown
Contributor

AI-assisted source re-review of 7ad3fb7; I have not run tests.

The async NotImplementedError hooks, facade-backed caller regressions, and updated no-database test selection address the four fallback paths and CI-selection gap raised in my earlier comment. The tests now exercise the community delegate, exact-name query, previous-episode result, and saga None sentinel followed by the summarization query.

Runtime validation is still pending: the Tests run for this head remains action_required.

@gkorland

Copy link
Copy Markdown
Contributor

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working scope:ci scope:core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] FalkorDB: get_by_group_ids returns empty for non-default groups — graph_operations_interface is never wired, so #1675's routing is unreachable

4 participants