Repository navigation
Fix #2033: [Bug] FalkorDB: get_by_group_ids returns empty for non-default groups - #2039
nandanadileep wants to merge 3 commits into
Conversation
|
AI-assisted source review of 92ddb3d; I have not executed these paths. The newly wired facade appears to break the fallback contract for four existing hooks: The effects are specific:
Could unsupported hooks preserve the Please also select the existing |
Preserve caller fallbacks for remove_communities, node_get_by_names, and the saga hooks. Fix ruff import order/format and collect the routing regressions in the no-database CI job. Co-authored-by: Nandana Dileep <nandanadileep@users.noreply.github.com>
Assert remove_communities, node_get_by_names, and the saga hooks still reach graph_ops and Cypher fallbacks, including the None sentinel that triggers summarization's query path. Co-authored-by: Nandana Dileep <nandanadileep@users.noreply.github.com>
|
AI-assisted source re-review of 7ad3fb7; I have not run tests. The async NotImplementedError hooks, facade-backed caller regressions, and updated no-database test selection address the four fallback paths and CI-selection gap raised in my earlier comment. The tests now exercise the community delegate, exact-name query, previous-episode result, and saga None sentinel followed by the summarization query. Runtime validation is still pending: the Tests run for this head remains action_required. |

Fixes #2033
What changed
Fixed
_make_adapteringraphiti_core/driver/falkordb/operations/graph_operations_interface.pyto drop the unbound interface method's leadingselfparameter before binding caller arguments, correcting the one-position argument shift that causedEpisodicNode.get_by_group_ids(and other classmethods) to pass thegroup_idslist as the executor and fail with'list' object has no attribute 'execute_query'.Verification
python -m pytest -q -x --import-mode=importlib tests/driver/test_falkordb_driver.py tests/driver/test_falkordb_ops_routing.pypassed