{{ message }}
Fix ONLYOFFICE Docs internal address rejected by Nextcloud - #6060
Open
rage-proof wants to merge 2 commits into
Open
Fix ONLYOFFICE Docs internal address rejected by Nextcloud#6060rage-proof wants to merge 2 commits into
rage-proof wants to merge 2 commits into
Conversation
…ores Document Server percent-escapes every '_' in the base URL of the signed URLs it returns, so addressing it by its injected container name made Nextcloud receive URLs with a '%5f' host, which its HTTP client refuses to send. Set container_name and point DOCS_INTERNAL_ADDRESS at it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Umbrel only offers an update when the manifest version changes, so the compose fix would otherwise reach new installs only. Release notes cover the one manual step: re-pasting the internal address in Nextcloud. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
App update — package fix. No image change; manifest
versionbumped9.4.0→9.4.0-1.App
App ID:
onlyoffice-nextcloudUpstream project: https://github.com/ONLYOFFICE/DocumentServer
Version: 9.4.0-1 (image unchanged at 9.4.0)
Summary
The app points Nextcloud at Document Server by its injected container name,
onlyoffice-nextcloud_documentserver_1. Document Server percent-escapesunderscores in the host of every signed URL it returns
(
storage-base.js:179),and Nextcloud's HTTP client rejects a percent escape in a host (guzzle 7.15.2,
GHSA-v5mv-p594-2x33):
On a stock install that means no office previews, failed conversions,
.doc/.xls/.pptfailing to save, and that error on the ONLYOFFICE admin page.Fix: give the service a hostname with no underscore in it.
Same resolution mechanism as before, same name shape as the injected one, just
-instead of_. Reported upstream too, but that fix needs a Document Serverrelease; this works today.
Manifest
versionis bumped to9.4.0-1with matching release notes, soexisting installs are offered the update — without it the fix would reach new
installs only.
Verification
Umbrel testing performed: not yet. Static checks only —
npm run lint:apps -- onlyoffice-nextcloud --check-imagesandgit diff --check. Per.claude/skills/umbrel-test-appthat is not Umbrelverification, so the update path still needs a runtime test on a device.
Environment tested:
Architecture tested:
Known lint warnings or caveats:
0 error(s). Same advisorysearxng,adventurelog,seafileandrustdesk-serveralready carry —searxngfor this exact reason.Notes
Existing installs keep the address stored in Nextcloud's app config and need to
paste the new one once (Admin → ONLYOFFICE → Advanced server settings), or:
occ config:app:set onlyoffice DocumentServerInternalUrl --value="http://onlyoffice-nextcloud-documentserver-1/"They are broken today regardless. No new permissions or dependencies.