{{ message }}
Repository navigation
fix: Use strict trace continuation for continue_from_span - #1329
Open
szokeasaurusrex wants to merge 1 commit into
Open
szokeasaurusrex wants to merge 1 commit into
szokeasaurusrex wants to merge 1 commit into
Conversation
szokeasaurusrex
added this pull request to stack #1332
September 22, 2026 13:39
szokeasaurusrex
force-pushed
the
szokeasaurusrex/continue_from_span-strict
branch
from
September 22, 2026 13:45
aff7363 to
35a2cee
Compare
szokeasaurusrex
commented
Sep 22, 2026
Comment on lines
+274
to
+283
Member
Author
There was a problem hiding this comment.
The changes here look more complicated than they really are; we needed to refactor the tuple used in the match statement to a named structure as incoming_trace is only available under the "client" feature.
Any other solution I could think of was more complicated
szokeasaurusrex
force-pushed
the
szokeasaurusrex/continue_from_span-strict
branch
from
September 22, 2026 13:49
35a2cee to
87541ba
Compare
szokeasaurusrex
marked this pull request as ready for review
September 22, 2026 13:49
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
szokeasaurusrex
marked this pull request as draft
September 22, 2026 13:53
The function `continue_from_span` allows continuing a distributed trace from a span that is spawned on another thread. Typically, both spans in this case are from the same Client, but if they are attached to different Clients it is also possible that they are associated with different org IDs. Anyways, to keep the handling of distributed traces consistent, it makes sense to populate `incoming_trace` in the `continue_from_span` method. As we will be adding more things to `IncomingTrace`, we should be using it consistently.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/continue_from_span-strict
branch
from
September 22, 2026 13:57
87541ba to
5c329fe
Compare
szokeasaurusrex
marked this pull request as ready for review
September 22, 2026 13:57
alexander-alderman-webb
approved these changes
Sep 23, 2026
Contributor
|
Is there a reason we introduce an |
Member
Author
giortzisg
approved these changes
Sep 24, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function
continue_from_spanallows continuing a distributed trace from a span that is spawned on another thread.Typically, both spans in this case are from the same Client, but if they are attached to different Clients it is also possible that they are associated with different org IDs.
Anyways, to keep the handling of distributed traces consistent, it makes sense to populate
incoming_tracein thecontinue_from_spanmethod. As we will be adding more things toIncomingTrace, we should be using it consistently.