{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 660
feat(huggingface): Support 1.0.0rc2 - #4873
#4873Merged
sentrivana merged 16 commits intoOct 6, 2025
mastergetsentry/sentry-python:masterfrom
ivana/support-huggingface_hub_v1getsentry/sentry-python:ivana/support-huggingface_hub_v1Copy head branch name to clipboard
Merged
feat(huggingface): Support 1.0.0rc2#4873sentrivana merged 16 commits intomastergetsentry/sentry-python:masterfrom ivana/support-huggingface_hub_v1getsentry/sentry-python:ivana/support-huggingface_hub_v1Copy head branch name to clipboard
sentrivana merged 16 commits into
mastergetsentry/sentry-python:masterfrom
ivana/support-huggingface_hub_v1getsentry/sentry-python:ivana/support-huggingface_hub_v1Copy head branch name to clipboard
Conversation
❌ 66 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
sentrivana
commented
Oct 3, 2025
Comment on lines
+77
to
+78
| MODEL_ENDPOINT.format(model_name=model_name) | ||
| + r"(\?expand=inferenceProviderMapping)?" |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
responses by default ignores the query string when looking for url matches, but pytest-httpx doesn't
sentrivana
marked this pull request as ready for review
October 3, 2025 07:52
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
sl0thentr0py
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Description
huggingface_hub has a release candidate out and our test suite doesn't work with it.
Two changes necessary:
httpx, so ourresponsesmocks don't work, we also needpytest_httpx.http.clientspans in the transaction, while before we were assuming the transaction only contains exactly onegen_ai.*span and nothing else.Issues
Closes #4802
Reminders
tox -e linters.feat:,fix:,ref:,meta:)