Make use of `SPANDATA` consistent in AI integrations.` by antonpirker · Pull Request #4376 · getsentry/sentry-python · GitHub
Skip to content

Make use of SPANDATA consistent in AI integrations.` - #4376

Merged
antonpirker merged 1 commit into
potel-basefrom
antonpirker/potel/spandata-consistency
May 9, 2025
Merged

antonpirker merged 1 commit into
potel-basefrom
antonpirker/potel/spandata-consistency

Conversation

@antonpirker

Copy link
Copy Markdown
Contributor

Not using plain strings, but always use SPANDATA. Follow up to this PR: #4373

@codecov

codecov Bot commented May 9, 2025

Copy link
Copy Markdown

@antonpirker
antonpirker marked this pull request as ready for review May 9, 2025 09:35
@antonpirker
antonpirker requested a review from a team as a code owner May 9, 2025 09:35

@szokeasaurusrex szokeasaurusrex left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did notice that there are fewer files changed here than in #4373 – I'm assuming these files don't exist in POTel?

@antonpirker

Copy link
Copy Markdown
Contributor Author

the other changes have already been made in the other PR. this one just adds the new occurences of not using SPANDATA that have been introduced in potel.

@antonpirker
antonpirker merged commit 07ba0f0 into potel-base May 9, 2025
@antonpirker
antonpirker deleted the antonpirker/potel/spandata-consistency branch May 9, 2025 09:44

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants