iframe-proxy

sentrivana · 2025-03-20T14:19:43Z

Remove the following deprecated stuff:

configure_debug_hub from debug.py
exported stuff in profiler/__init__.py that's not part of public API and was only exported for backwards compat reasons
support for _experiments['profiler_mode'] and _experiments['profiles_sample_rate'] which both have non-experimental top-level options now
Transport.capture_event
_FunctionTransport and support for function transports in general
enable_tracing

codecov · 2025-03-20T14:22:20Z

❌ 901 Tests Failed:

View the top 3 failed test(s) by shortest run time

 tests.integrations.celery.integration_tests.test_celery_beat_cron_monitoring

Stack Traces | 0s run time

.../hostedtoolcache/Python/3.7.17.../x64/lib/python3.7/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1006: in _gcd_import
    ???
<frozen importlib._bootstrap>:983: in _find_and_load
    ???
<frozen importlib._bootstrap>:953: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:219: in _call_with_frames_removed
    ???
<frozen importlib._bootstrap>:1006: in _gcd_import
    ???
<frozen importlib._bootstrap>:983: in _find_and_load
    ???
<frozen importlib._bootstrap>:967: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:677: in _load_unlocked
    ???
<frozen importlib._bootstrap_external>:728: in exec_module
    ???
<frozen importlib._bootstrap>:219: in _call_with_frames_removed
    ???
.../celery/integration_tests/__init__.py:7: in <module>
    from celery.beat import Scheduler
.tox/py3.7-celery-v5.0.5/lib/python3.7.../site-packages/celery/beat.py:22: in <module>
    from . import __version__, platforms, signals
.tox/py3.7-celery-v5.0.5/lib/python3.7.../site-packages/celery/signals.py:14: in <module>
    from .utils.dispatch import Signal
.tox/py3.7-celery-v5.0.5/lib/python3.7.../celery/utils/__init__.py:16: in <module>
    from .nodenames import nodename, nodesplit, worker_direct
.tox/py3.7-celery-v5.0.5/lib/python3.7.../celery/utils/nodenames.py:6: in <module>
    from kombu.entity import Exchange, Queue
.tox/py3.7-celery-v5.0.5/lib/python3.7.../site-packages/kombu/entity.py:7: in <module>
    from .serialization import prepare_accept_content
.tox/py3.7-celery-v5.0.5/lib/python3.7.../site-packages/kombu/serialization.py:440: in <module>
    for ep, args in entrypoints('kombu.serializers'):  # pragma: no cover
.tox/py3.7-celery-v5.0.5/lib/python3.7.../kombu/utils/compat.py:82: in entrypoints
    for ep in importlib_metadata.entry_points().get(namespace, [])
E   AttributeError: 'EntryPoints' object has no attribute 'get'

 tests.integrations.celery.test_celery

Stack Traces | 0s run time

ImportError while importing test module '.../integrations/celery/test_celery.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
.tox/py3.7-celery-v5.0.5/lib/python3.7.../site-packages/_pytest/python.py:617: in _importtestmodule
    mod = import_path(self.path, mode=importmode, root=self.config.rootpath)
.tox/py3.7-celery-v5.0.5/lib/python3.7.../site-packages/_pytest/pathlib.py:567: in import_path
    importlib.import_module(module_name)
.../hostedtoolcache/Python/3.7.17.../x64/lib/python3.7/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1006: in _gcd_import
    ???
<frozen importlib._bootstrap>:983: in _find_and_load
    ???
<frozen importlib._bootstrap>:967: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:677: in _load_unlocked
    ???
.tox/py3.7-celery-v5.0.5/lib/python3.7.../_pytest/assertion/rewrite.py:186: in exec_module
    exec(co, module.__dict__)
.../integrations/celery/test_celery.py:6: in <module>
    from celery import Celery, VERSION
E   ImportError: cannot import name 'Celery' from 'celery' (.../sentry-python/sentry-python/.tox/py3.7-celery-v5.0.5/lib/python3.7.../site-packages/celery/__init__.py)

 tests.integrations.celery.test_update_celery_task_headers

Stack Traces | 0s run time

.../integrations/celery/beat.py:28: in <module>
    from celery import Task, Celery  # type: ignore
E   ImportError: cannot import name 'Task' from 'celery' (.../sentry-python/sentry-python/.tox/py3.7-celery-v5.0.5/lib/python3.7.../site-packages/celery/__init__.py)

During handling of the above exception, another exception occurred:
.../integrations/celery/test_update_celery_task_headers.py:7: in <module>
    from sentry_sdk.integrations.celery import _update_celery_task_headers
.../integrations/celery/__init__.py:9: in <module>
    from sentry_sdk.integrations.celery.beat import (
.../integrations/celery/beat.py:37: in <module>
    raise DidNotEnable("Celery not installed")
E   sentry_sdk.integrations.DidNotEnable: Celery not installed

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

szokeasaurusrex

[optional] I would prefer a separate PR for each item being removed to make it easier to review this change, and to be able to see each item being dropped in the Git history. Though since @sl0thentr0py already approved this PR, I won't block merging because of this

antonpirker

nice!

sentrivana added 2 commits March 20, 2025 14:41

chore: Drop more deprecated things

22eeba1

profiler stuff

3d0f50c

sentrivana added 2 commits March 20, 2025 15:25

slim down profiler init

96d8460

fix import

ca46ffc

sentrivana changed the title ~~chore: Drop more deprecated things~~ chore: Drop more deprecated stuff Mar 20, 2025

sentrivana added 3 commits March 20, 2025 15:38

remove enable_tracing

168be8c

missing initialization

2422b21

migration guide

96110f7

sentrivana marked this pull request as ready for review March 20, 2025 14:54

sentrivana requested review from antonpirker, sl0thentr0py and szokeasaurusrex March 20, 2025 14:55

sl0thentr0py approved these changes Mar 20, 2025

View reviewed changes

This is also the enable_tracing init option.

89a6509

szokeasaurusrex reviewed Mar 20, 2025

View reviewed changes

antonpirker approved these changes Mar 20, 2025

View reviewed changes

sentrivana merged commit 0cd2bce into potel-base Mar 21, 2025

sentrivana deleted the ivana/potel/drop-more-deprecations branch March 21, 2025 08:03

sentrivana mentioned this pull request Mar 21, 2025

POtel implementation base branch (aka SDK 3.0.0) #3152

Closed

BYK mentioned this pull request Sep 3, 2025

breaking: Remove Spotlight Django integration #4747

Merged

sentrivana mentioned this pull request Oct 15, 2025

create a prioritised list of improvements to be backported from potel-base #4922

Closed

dingsdax mentioned this pull request Oct 15, 2025

Prepare issues for next major #4933

Closed

sentrivana mentioned this pull request Oct 24, 2025

Drop deprecated stuff #5011

Closed

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Uh oh!

chore: Drop more deprecated stuff - #4176

chore: Drop more deprecated stuff#4176
sentrivana merged 8 commits into
potel-basefrom
ivana/potel/drop-more-deprecations

sentrivana commented Mar 20, 2025 •

edited

Loading

Uh oh!

codecov Bot commented Mar 20, 2025 •

edited

Loading

Uh oh!

szokeasaurusrex left a comment

Uh oh!

antonpirker left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

sentrivana commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 901 Tests Failed:

Uh oh!

szokeasaurusrex left a comment

Choose a reason for hiding this comment

Uh oh!

antonpirker left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sentrivana commented Mar 20, 2025 •

edited

Loading

codecov Bot commented Mar 20, 2025 •

edited

Loading