Setup scopes before client by sl0thentr0py · Pull Request #3916 · getsentry/sentry-python · GitHub
Skip to content

Setup scopes before client - #3916

Merged
sl0thentr0py merged 1 commit into
potel-basefrom
neel/potel/reorder-init-scope
Jan 10, 2025
Merged

sl0thentr0py merged 1 commit into
potel-basefrom
neel/potel/reorder-init-scope

Conversation

@sl0thentr0py

Copy link
Copy Markdown
Member

The newly added feature flags add an error processor to current_scope in their setup_once. This is actually an antipattern and shouldn't be encouraged.
Either way, this PR sets up the scopes first since the integrations get setup in the Client and require that scope to be correct.

@codecov

codecov Bot commented Jan 10, 2025

Copy link
Copy Markdown

@antonpirker antonpirker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sl0thentr0py
sl0thentr0py merged commit ab5d8a7 into potel-base Jan 10, 2025
@sl0thentr0py
sl0thentr0py deleted the neel/potel/reorder-init-scope branch January 10, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants