{{ message }}
Fix httpx tests - #3810
Merged
Merged
Fix httpx tests#3810
Conversation
sentrivana
approved these changes
Nov 21, 2024
sentrivana
left a comment
sentrivana
left a comment
Contributor
There was a problem hiding this comment.
Lgtm. Just one small q.
Comment on lines
+303
to
+304
Contributor
There was a problem hiding this comment.
Do you know why we were expecting to not propagate in the original version of this test case? The updated behavior is what I'd have expected to always be the case
Member
Author
There was a problem hiding this comment.
was part of this change
#3070
and I believe this was an unintended side effect of that change...
but now we fixed the span without transaction problem another way with only_if_parent and this is the desired twp behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.