{{ message }}
Extract span attrs from RQ job object & fix tests - #3786
Merged
Merged
Conversation
sentrivana
changed the title
sentrivana
commented
Nov 21, 2024
| @ensure_integration_enabled(RqIntegration, old_perform_job) | ||
| def sentry_patched_perform_job(self, job, *args, **kwargs): | ||
| # type: (Any, Job, *Queue, **Any) -> bool | ||
| def sentry_patched_perform_job(self, job, queue, *args, **kwargs): |
Contributor
Author
There was a problem hiding this comment.
Checked that the signature of perform_job is stable in the minimal supported version and in the current release. There are actually no args and kwargs, just job and queue, but let's do it like this for forwards compat.
sentrivana
marked this pull request as ready for review
November 21, 2024 15:28
sl0thentr0py
approved these changes
Nov 21, 2024
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rq_jobwith some span attrs to populate the sampling context in traces samplertest_rqpassmessageif we already explicitly setopThis is not great since we have to serialize everything (args, kwargs, function to be executed). But it's the best we can do with span attrs.