Sample on root span level by sentrivana · Pull Request #3767 · getsentry/sentry-python · GitHub
Skip to content

Sample on root span level - #3767

Merged
sentrivana merged 13 commits into
potel-basefrom
ivana/potel/fix-sampler
Nov 14, 2024
Merged

Sample on root span level#3767
sentrivana merged 13 commits into
potel-basefrom
ivana/potel/fix-sampler

Conversation

@sentrivana

@sentrivana sentrivana commented Nov 13, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • for spans that have a local parent (i.e., non-root spans/transactions), just inherit the sampling decision from the parent
  • update some tests

Closes #3766

@codecov

codecov Bot commented Nov 13, 2024 •
edited
Loading

Copy link
Copy Markdown

sentrivana
sentrivana commented Nov 13, 2024
View reviewed changes
Comment thread sentry_sdk/tracing.py Outdated
@sentrivana
sentrivana marked this pull request as ready for review November 13, 2024 10:35
@sentrivana sentrivana mentioned this pull request Nov 13, 2024
Merged
sl0thentr0py
sl0thentr0py requested changes Nov 13, 2024
View reviewed changes
Comment thread sentry_sdk/integrations/opentelemetry/sampler.py Outdated
Comment thread sentry_sdk/tracing.py Outdated
@sentrivana

sentrivana commented Nov 13, 2024

Copy link
Copy Markdown
Contributor Author

@sl0thentr0py Removed parent_sampled and updated the tests a bit more, please recheck

sl0thentr0py
sl0thentr0py requested changes Nov 14, 2024
View reviewed changes
Comment thread tests/tracing/test_sampling.py Outdated

@sl0thentr0py sl0thentr0py Nov 14, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test should mirror the one above where you added the continue_trace

@sentrivana
sentrivana merged commit ff7e134 into potel-base Nov 14, 2024
@sentrivana
sentrivana deleted the ivana/potel/fix-sampler branch November 14, 2024 10:58
@sentrivana sentrivana mentioned this pull request Nov 14, 2024
Closed
@BYK BYK mentioned this pull request Sep 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes
@antonpirker antonpirker Awaiting requested review from antonpirker

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sentrivana @sl0thentr0py