Fix WSGI tests by sl0thentr0py · Pull Request #3734 · getsentry/sentry-python · GitHub
Skip to content

Fix WSGI tests - #3734

Merged
sl0thentr0py merged 1 commit into
potel-basefrom
neel/potel/fix-wsgi
Nov 5, 2024
Merged

sl0thentr0py merged 1 commit into
potel-basefrom
neel/potel/fix-wsgi

Conversation

@sl0thentr0py

@sl0thentr0py sl0thentr0py commented Nov 5, 2024

Copy link
Copy Markdown
Member
  • Don't default to OK span status for UNSET, this breaks older behavior
  • Set transaction name manually on scope after isolation (we should generally do this everywhere)
    • This is necessary because now unsampled (so when performance is off, for instance) spans are NonRecordingSpans and therefore have no attributes - this is completely different behavior than our older tracing spans since we have active spans but they carry NO DATA.

* Don't default to OK span status for UNSET, this breaks older behavior
* Set transaction name manually on scope after isolation (we should
  generally do this everywhere)
@codecov

codecov Bot commented Nov 5, 2024

Copy link
Copy Markdown

@sl0thentr0py
sl0thentr0py merged commit fb66e1a into potel-base Nov 5, 2024
@sl0thentr0py
sl0thentr0py deleted the neel/potel/fix-wsgi branch November 5, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants