{{ message }}
Add root_span implementation - #3513
Merged
Merged
Conversation
sl0thentr0py
force-pushed
the
neel/potel/root-span
branch
from
September 10, 2024 11:40
630b0bf to
33b8c13
Compare
sentrivana
approved these changes
Sep 10, 2024
sentrivana
left a comment
sentrivana
left a comment
Contributor
There was a problem hiding this comment.
Nice, and looks pretty non-invasive, too 👍🏻 Left one nit
* add and track underlying root span in a hidden attr `_sentry_root_otel_span` in all subsequent children spans in the span processor on start * wrap this underlying root otel span in a `POTelSpan` to act as a proxy * make `POTelSpan` constructor work with explicitly passed in `otel_span` * implement `__eq__` on `POTelSpan` to make sure proxies to the same underlying `_otel_span` are considered the same
sl0thentr0py
force-pushed
the
neel/potel/root-span
branch
from
September 10, 2024 12:01
33b8c13 to
56ef079
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_sentry_root_otel_spanin all subsequent children spans in the span processor on startPOTelSpanto act as a proxyPOTelSpanconstructor work with explicitly passed inotel_span__eq__onPOTelSpanto make sure proxies to the same underlying_otel_spanare considered the same