{{ message }}
feat(redis): Add support for redis.asyncio - #1933
Merged
Merged
Conversation
Zhenay
force-pushed
the
Zhenay/931-redis-asyncio
branch
from
March 1, 2023 16:19
647884f to
7539af7
Compare
Contributor
antonpirker
reviewed
Jul 10, 2023
antonpirker
left a comment
antonpirker
left a comment
Contributor
There was a problem hiding this comment.
Looks good so far. Will do some manual testing now.
Contributor
|
I added the PII scrubbing function for pipeline commands that we had in place at another place already, for not leaking PII accidentally |
antonpirker
approved these changes
Jul 11, 2023
antonpirker
left a comment
antonpirker
left a comment
Contributor
There was a problem hiding this comment.
Looks good and does what it should. Ready for shipping this!
Contributor
antonpirker
enabled auto-merge (squash)
July 11, 2023 08:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #931