Link errors to OTel spans by antonpirker · Pull Request #1787 · getsentry/sentry-python · GitHub
Skip to content

Link errors to OTel spans - #1787

Merged
antonpirker merged 10 commits into
masterfrom
antonpirker/1786-link-errors-to-otel-spans
Dec 19, 2022
Merged

antonpirker merged 10 commits into
masterfrom
antonpirker/1786-link-errors-to-otel-spans

Conversation

@antonpirker

@antonpirker antonpirker commented Dec 15, 2022

Copy link
Copy Markdown
Contributor

This links Sentry errors to performance spans originated in OTel. Fixes #1786

@antonpirker antonpirker changed the title Add trace information to error events Link errors to OTel spans Dec 15, 2022

@adinauer adinauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM; maybe check instrumenter and use OTEL method/constant

Comment thread sentry_sdk/integrations/opentelemetry/span_processor.py Outdated
Comment thread sentry_sdk/integrations/opentelemetry/span_processor.py Outdated
@adinauer

Copy link
Copy Markdown
Member

@antonpirker

Copy link
Copy Markdown
Contributor Author

@antonpirker
antonpirker merged commit 6959941 into master Dec 19, 2022
@antonpirker
antonpirker deleted the antonpirker/1786-link-errors-to-otel-spans branch December 19, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link errors to OTel spans

2 participants