chore(ci): Vendor nx-affected-list action, drop dkhunt27 dependency by mydea · Pull Request #20463 · getsentry/sentry-javascript · GitHub
Skip to content

chore(ci): Vendor nx-affected-list action, drop dkhunt27 dependency#20463

Open
mydea wants to merge 3 commits intodevelopfrom
fn/vendor-nx-affected-list
Open

chore(ci): Vendor nx-affected-list action, drop dkhunt27 dependency#20463
mydea wants to merge 3 commits intodevelopfrom
fn/vendor-nx-affected-list

Conversation

@mydea
Copy link
Copy Markdown
Member

@mydea mydea commented Apr 23, 2026

Summary

Replace the third-party dkhunt27/action-nx-affected-list@v6.1 with a vendored composite action at .github/actions/nx-affected-list/.

Why:

  • The external action is outdated (last release Sep 2024) and uses Node.js 20 (GHA deprecation warning)
  • It's a heavy wrapper (~200 lines of compiled JS) around a single command: nx show projects --affected
  • Third-party CI dependencies are a supply chain risk

What the external action did:

  1. nx --version + nx reset (prep)
  2. nx show projects --affected --base=X --head=Y (core logic)
  3. Parse output into a list, set as action output

What the vendored action does:

  • Runs nx show projects --affected directly in bash (~15 lines)
  • Outputs space-separated project names (compatible with existing contains() checks)
  • No Node.js runtime dependency, no nx reset (unnecessary in our setup)

🤖 Generated with Claude Code

@mydea mydea self-assigned this Apr 23, 2026
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 97e427a. Configure here.

Comment thread .github/actions/nx-affected-list/action.yml Outdated
Comment thread .github/actions/nx-affected-list/action.yml Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 23, 2026

@mydea mydea force-pushed the fn/vendor-nx-affected-list branch from 240bae7 to 8558dc3 Compare April 24, 2026 08:32
mydea and others added 3 commits April 24, 2026 11:17
Replace the third-party dkhunt27/action-nx-affected-list@v6.1 with a
lightweight composite action that runs `nx show projects --affected`
directly. The external action was outdated (last release Sep 2024,
uses Node.js 20) and all it did was shell out to the nx CLI.

The vendored action is ~15 lines of bash with no Node.js runtime
dependency.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@mydea mydea force-pushed the fn/vendor-nx-affected-list branch from 8558dc3 to 2832b37 Compare April 24, 2026 09:17
@mydea mydea requested review from andreiborza and isaacs April 24, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant