{{ message }}
feat(browser): Add ingest_settings to span v2 envelope payload#20411
Draft
nicohrubec wants to merge 6 commits intodevelopfrom
Draft
feat(browser): Add ingest_settings to span v2 envelope payload#20411nicohrubec wants to merge 6 commits intodevelopfrom
ingest_settings to span v2 envelope payload#20411nicohrubec wants to merge 6 commits intodevelopfrom
Conversation
Contributor
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a98a9ce. Configure here.
chargome
reviewed
Apr 21, 2026
| ...(!!tunnel && dsn && { dsn: dsnToString(dsn) }), | ||
| }; | ||
|
|
||
| const isBrowserSdk = options._metadata?.sdk?.name === 'sentry.javascript.browser'; |
Member
There was a problem hiding this comment.
As discussed offline, we'll likely need better detection here for covering all browser based SDKs
Member
Author
|
@chargome updated the detection to use |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
version: 2andingest_settingsto the span streaming envelope payload so Relay can infer the end-user IP address and User-Agent from the incoming request (link to spec). This is only emitted by the browser SDK.Both settings are currently gated behind
sendDefaultPii(modeled after howevent.sdk.settings.infer_ipworks today, but maybe we should confirm this).We'll wait on getsentry/relay#5869 to be implemented before sending this.
Closes #20275