{{ message }}
fix(test): isolate repositories test to prevent response cache bleed#864
Merged
Conversation
useTestConfigDir gives each test its own config directory so the disk-based HTTP response cache from test 2 doesn't serve stale data to test 3, which was causing the CI failure on main.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix flaky
test/lib/api/repositories.test.tsfailure on main:Root Cause
The test file was missing
useTestConfigDir(), so all three tests shared the same config directory and disk-based HTTP response cache. Test 2's API response got cached to~/.sentry/cache/responses/, and test 3 was served that stale cached response instead of hitting its own fetch mock.Every other API test file (
issues.test.ts,organizations.test.ts,releases.test.ts) already usesuseTestConfigDir()— this one was the outlier.Fix
useTestConfigDir("repo-cache-")for per-test config directory isolationsetAuthToken()inbeforeEachto provide the auth tokenauthenticatedFetchneeds