{{ message }}
feat(debug-files): migrate DIF parser to the Archive/ObjectFile API#1124
Merged
Conversation
The new @sentry/symbolic 13.4.0 (getsentry/symbolic#992, #993) replaces the flat parse_debug_file/peek_format functions with an Archive/ObjectFile class API. Rewrite src/lib/dif/index.ts onto it: - parseDebugFile -> new Archive(data) + archive.objects() with the camelCase getters (debugId, codeId, arch, fileFormat, kind, has*). - peekFormat -> Archive.peek(data) ?? "unknown" (peek now returns undefined for an unrecognized format). - Drop the snake_case RawArchiveInfo bridging type. The public TS surface (parseDebugFile, peekFormat, DifArchiveInfo, DifObjectInfo) is unchanged, so debug-files/check.ts and the tests are untouched. Bumps @sentry/symbolic 13.3.0 -> 13.4.0. Validated: typecheck clean and dif unit tests 9/9 against the published 13.4.0.
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the DIF parser onto the new
@sentry/symbolic13.4.0 API (getsentry/symbolic#992 + #993), which replaced the flatparse_debug_file/peek_formatfunctions with anArchive/ObjectFileclass API.Changes
src/lib/dif/index.ts:parseDebugFile→new Archive(data)+archive.objects()with the camelCase getters (debugId,codeId,arch,fileFormat,kind,has*).peekFormat→Archive.peek(data) ?? "unknown"(peeknow returnsundefinedfor an unrecognized format, matching the old"unknown").RawArchiveInfobridging type.@sentry/symbolic13.3.0→13.4.0.The public TS surface (
parseDebugFile,peekFormat,DifArchiveInfo,DifObjectInfo) is unchanged, sodebug-files/check.tsand the existing tests are untouched.Validation
Against the published
13.4.0:tsc --noEmitclean,test/lib/dif/index.test.ts9/9.