iframe-proxy

kr1shna-exe · 2026-10-06T19:45:41Z

Description

Task terminals now show up in the Add context popover (Cmd+Shift+A in a conversation). Picking one pastes that terminal's output into the active agent session, the same way linked issues and line comments already get pasted in:

If the terminal has a selection, only the selection is sent.
Otherwise the last 200 lines are sent, with soft-wrapped rows joined back into their original lines and the empty rows below the cursor dropped.
The text is wrapped in a fenced block labelled with the terminal name. The fence gets longer when the output itself contains backticks.

The output is read when you pick the entry, not when the list is built. Terminals whose tab was never opened get connected first, and the app waits for the replayed scrollback to finish before reading, so you get current output either way.

Implementation notes:

terminals/api/browser/pty/terminal-output.ts reads the xterm buffer.
context-actions.ts gains a terminal-output action.
AddContextPopover.onApplyAction now receives just the action. ContextBar resolves the text itself, since terminal text has to be read asynchronously.

One visible side effect: the context bar now appears in any task that has a terminal, even when there's no linked issue, comment or prompt. It can still be hidden from its right-click menu.

Related issues

Closes #2769

Testing

pnpm run format:check, pnpm run lint and pnpm run typecheck in apps/emdash-desktop pass.
vitest run --project node: 3927 passed. The one failure is files-domain.integration.test.ts "classifies a path outside any checkout as an unavailable content state", which fails the same way on main.
New tests: terminal-output.test.ts runs a real xterm Terminal and covers wrapped lines, the line cap, spaces on a wrap boundary, selection taking priority and an empty buffer. context-actions.test.ts covers ordering, fencing and reading at apply time.
Ran the dev app with a task whose agent CLI was pointed at a script that echoes its input. I created two terminals and ran commands in them without opening their tabs. Both showed up in the popover. Picking Terminal 1 pasted its output. Searching "terminal 2" and picking it pasted rows 102 to 300 plus the prompt (the last 200 lines). With one line selected in Terminal 1, only that line was pasted.

Screenshot/Recording (if applicable)

Popover with both terminals listed: 07-popover.png
Selected line pasted into the agent: 11-after-selection.png

Checklist

I kept this PR small and focused
I ran a self-review before opening this PR
I ran the relevant local checks or explained why not
I updated docs when behavior or setup changed
I added or updated tests when behavior changed, or explained why not
I only added comments where the logic is not obvious
I used Conventional Commits for commit
messages and, when possible, the PR title

Task terminals now show up in the Add context popover. Picking one pastes the terminal's current selection, or its last 200 lines when nothing is selected, into the active agent session as a fenced block. Refs: generalaction#2769

greptile-apps · 2026-10-06T19:51:40Z

Confidence Score: 4/5

[Medium risk] Adds terminal output as a context option for tasks.

The PR appears safe to merge, with non-blocking improvements for large output and failed terminal reads.

Findings

Large terminal output fails ▶
Failed reads give no explanation ▶

Fix with agent prompt

### Issue 1
apps/emdash-desktop/src/core/features/tasks/browser/context-bar/context-actions.ts:70
`formatTerminalOutputForAgent` passes every backtick run to `Math.max` as a separate argument. A large selection or long wrapped line can exceed JavaScript's argument limit, so adding that output throws instead of pasting it. The 200-line limit does not bound the text size. Find the longest run with a loop or reduction instead.

```suggestion
  let longestBacktickRun = 0;
  for (const match of output.matchAll(/`+/g)) {
    longestBacktickRun = Math.max(longestBacktickRun, match[0].length);
  }
```

### Issue 2
apps/emdash-desktop/src/core/features/tasks/contributions/browser/context-bar.tsx:79
The new `await readContextActionText(action)` can reject when an unopened terminal fails to connect or load its saved output. `handleApplyAction` does not catch that error, and `AddContextPopover` discards its promise and closes immediately. The user gets neither the output nor an explanation. Catch failures from the new read and show a retryable error.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Adds task terminals to the Add context menu. Picking a terminal reads its selection or recent output, wraps it in a named fenced block, and pastes it into the chosen conversation.

Connects unopened terminals and waits for saved output before reading.
Adds tests for text extraction, action ordering, fencing, and reading at apply time.
Two non-blocking improvements remain: avoid spreading unbounded matches into Math.max, and show errors when terminal reads fail.

Diagram

sequenceDiagram
  participant User
  participant Menu as Add context menu
  participant Session as Terminal session
  participant Buffer as xterm buffer
  participant Agent as Conversation
  User->>Menu: Pick terminal
  Menu->>Session: Connect if needed
  Session->>Buffer: Queue saved output
  Session-->>Menu: Connection ready
  Menu->>Buffer: Wait for queued writes
  Menu->>Buffer: Read selection or last 200 logical lines
  Menu->>Menu: Add name and fence
  Menu->>Agent: Paste text

_{Reviews (1) · Last reviewed commit: "feat(tasks): add terminal output to the ..."}

Find the longest backtick run with a loop instead of spreading every match into Math.max, which overflowed the call stack on large output. Show a toast when reading a terminal fails instead of dropping the error.

feat(tasks): add terminal output to the add context menu

3f51f59

Task terminals now show up in the Add context popover. Picking one pastes the terminal's current selection, or its last 200 lines when nothing is selected, into the active agent session as a fenced block. Refs: generalaction#2769

greptile-apps Bot reviewed Oct 6, 2026

View reviewed changes

Comment thread apps/emdash-desktop/src/core/features/tasks/browser/context-bar/context-actions.ts Outdated

Comment thread apps/emdash-desktop/src/core/features/tasks/contributions/browser/context-bar.tsx Outdated

fix(tasks): handle large and failed terminal context reads

bc24fc9

Find the longest backtick run with a loop instead of spreading every match into Math.max, which overflowed the call stack on large output. Show a toast when reading a terminal fails instead of dropping the error.

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Repository navigation

feat(tasks): add terminal output to the add context menu - #3301

feat(tasks): add terminal output to the add context menu#3301
kr1shna-exe wants to merge 2 commits into
generalaction:mainfrom
kr1shna-exe:feat/2769-terminal-output-context

kr1shna-exe commented Oct 6, 2026

Uh oh!

greptile-apps Bot commented Oct 6, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

kr1shna-exe commented Oct 6, 2026

Description

Related issues

Testing

Screenshot/Recording (if applicable)

Uh oh!

greptile-apps Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 4/5

Findings

Summary

Diagram

Uh oh!

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

greptile-apps Bot commented Oct 6, 2026 •

edited

Loading