{{ message }}
Repository navigation
Conversation
The View menu's zoomIn role defaults to `CmdOrCtrl+Plus`, which needs Shift on most layouts and doesn't fire for a bare `Ctrl+=` on Windows/Linux, so zoom-in appeared missing while zoom-out and reset worked. Add hidden menu aliases for `CmdOrCtrl+=` and the numpad +/-/0 keys, keeping the visible menu unchanged. Fixes generalaction#3182
Contributor
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+175
to
+180
Contributor
There was a problem hiding this comment.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/emdash-desktop/src/main/host/menu.ts
Line: 175-180
Comment:
**Zoom aliases lack verification** The four hidden shortcuts are not covered by the existing menu tests, and the PR lists no manual keyboard checks. A focused menu-template test and documented checks on the supported platforms would make it easier to catch a shortcut regression.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The View menu's zoomIn role defaults to
CmdOrCtrl+Plus, which needs Shift on most layouts and doesn't fire for a bareCtrl+=on Windows/Linux, so zoom-in appeared missing while zoom-out and reset worked.Add hidden menu aliases for
CmdOrCtrl+=and the numpad +/-/0 keys, keeping the visible menu unchanged.Fixes #3182
Description
Give a short summary of what changed, why it's needed, and any important implementation notes.
Related issues
Link related issues. If this PR fixes an issue, mention it like: Fixes #123.
Testing
List the checks you ran, for example
pnpm run format,pnpm run lint,pnpm run typecheck,pnpm run test, and any manual testing.Screenshot/Recording (if applicable)
Attach a screenshot, GIF, or recording of the change. This is optional, but helps reviewers
understand UI or workflow changes.
Checklist
messages and, when possible, the PR title