{{ message }}
Fix CI test failure by fixing SETTINGS_DIRECTORY_NAME#58
Merged
Conversation
WalkthroughThe settings directory name is now computed based on the CI environment: it becomes ".gemini" when CI is detected and ".gen-cli" otherwise. The public export SETTINGS_DIRECTORY_NAME now references this computed value. No other logic or APIs are changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
packages/cli/src/config/settings.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (GEMINI.md)
**/*.{ts,tsx}: Prefer plain JavaScript objects with TypeScript interfaces/types over JavaScript classes throughout the codebase
Use ES module exports to define the public API; keep non-exported items private. Avoid testing or accessing unexported internals; extract them to their own module if needed
Avoidanyand type assertions; preferunknownand perform explicit type narrowing instead
Inswitchstatements over discriminated unions or enums, use thecheckExhaustivehelper in the default clause to ensure exhaustiveness
Prefer array operators (map,filter,reduce,slice,sort, etc.) to write immutable, declarative data transformations instead of imperative loops
Files:
packages/cli/src/config/settings.ts
🧬 Code graph analysis (1)
packages/cli/src/config/settings.ts (1)
scripts/telemetry.js (1)
SETTINGS_DIRECTORY_NAME(15-15)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: CodeQL
- GitHub Check: Lint (Javascript)
Comment on lines
+24
to
+25
| const CUSTOM_DIRECTORY_NAME = process.env['CI'] ? '.gemini' : '.gen-cli'; | ||
| export const SETTINGS_DIRECTORY_NAME = CUSTOM_DIRECTORY_NAME; |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Derive the CI directory from GEMINI_CONFIG_DIR and avoid duplicating the '.gemini' literal
Right now we hard-code '.gemini' here, while the rest of the module already imports GEMINI_CONFIG_DIR. Basing the CI branch on GEMINI_DIR avoids future drift if the core value changes and keeps a single source of truth. This also lets us drop the extra internal variable.
Apply this minimal diff within the same lines:
-const CUSTOM_DIRECTORY_NAME = process.env['CI'] ? '.gemini' : '.gen-cli';
-export const SETTINGS_DIRECTORY_NAME = CUSTOM_DIRECTORY_NAME;
+export const SETTINGS_DIRECTORY_NAME =
+ process.env['CI'] ? GEMINI_DIR : '.gen-cli';Optional hardening (outside the selected lines): if you want stricter CI detection across providers, consider normalizing CI to boolean and adding a brief JSDoc explaining why we diverge in CI.
Verification script to spot remaining hard-coded occurrences and ensure consistency across the repo:
Expected: Any remaining hard-coded '.gemini' (e.g., scripts/telemetry.js) are intentional or get refactored to use the same source of truth to prevent divergence between scripts and the CLI.
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Usages of SETTINGS_DIRECTORY_NAME:"
rg -n -C2 --type=ts '\bSETTINGS_DIRECTORY_NAME\b' || true
echo
echo "Hard-coded '.gemini' and '.gen-cli' literals:"
rg -n -C2 -S "['\"]\\.gemini['\"]|['\"]\\.gen-cli['\"]" || true
echo
echo "References to GEMINI_CONFIG_DIR:"
rg -n -C2 'GEMINI_CONFIG_DIR' || trueLength of output: 35731
Derive the CI directory from GEMINI_CONFIG_DIR and centralize the “.gemini” literal
Use the imported GEMINI_CONFIG_DIR (aliased as GEMINI_DIR) to decide the CI path, drop the CUSTOM_DIRECTORY_NAME helper, and inline the conditional:
--- a/packages/cli/src/config/settings.ts
+++ b/packages/cli/src/config/settings.ts
@@ -23,3 +23,5 @@ export type { Settings, MemoryImportFormat };
-const CUSTOM_DIRECTORY_NAME = process.env['CI'] ? '.gemini' : '.gen-cli';
-export const SETTINGS_DIRECTORY_NAME = CUSTOM_DIRECTORY_NAME;
+export const SETTINGS_DIRECTORY_NAME =
+ process.env['CI'] ? GEMINI_DIR : '.gen-cli';• Remove CUSTOM_DIRECTORY_NAME and inline the CI check against GEMINI_DIR.
• (Optionally) Add a JSDoc on SETTINGS_DIRECTORY_NAME to explain the CI divergence and normalize CI to a boolean.
Mandatory follow-ups:
- packages/cli/src/config/trustedFolders.ts currently re-exports
Update it to import the new
export const SETTINGS_DIRECTORY_NAME = '.gemini';
SETTINGS_DIRECTORY_NAME(orGEMINI_DIR) fromsettings.tsto avoid a second source of truth. - Review all remaining hard-coded occurrences of
'.gemini'and'.gen-cli'(in scripts, tests, etc.) and switch them to the centralized constants where appropriate. - Re-run your verification script to confirm no unintended literals remain or diverge.
This ensures a single source of truth for all Gemini-related directory names and prevents future drift.
🤖 Prompt for AI Agents
In packages/cli/src/config/settings.ts around lines 24-25, remove the
CUSTOM_DIRECTORY_NAME variable and inline the conditional so
SETTINGS_DIRECTORY_NAME uses the imported GEMINI_CONFIG_DIR (GEMINI_DIR) to
decide between '.gemini' and '.gen-cli' (normalize process.env.CI to a boolean
first); optionally add a short JSDoc on SETTINGS_DIRECTORY_NAME noting the CI
divergence. Then update packages/cli/src/config/trustedFolders.ts to stop
exporting the hard-coded '.gemini' and instead import and re-export
SETTINGS_DIRECTORY_NAME (or GEMINI_DIR) from settings.ts to centralize the
value, and search the repo for remaining literal occurrences of '.gemini' and
'.gen-cli' (scripts, tests, etc.) replacing them with the centralized constant
and re-run verification.
Code Coverage SummaryCLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Dive Deeper
Reviewer Test Plan
Testing Matrix
Linked issues / bugs
Summary by CodeRabbit