Conversation
msullivan
force-pushed
the
auto-rr
branch
2 times, most recently
from
2b918de to
7a176d0
Compare
One danger of adding the enum value is possible confusion that it's a setting that the server supports (but this is minor since we'll add this server-side in 7). Interface-wise, we should make |
I'm not sold on that exactly. What would be the interaction with explicitly setting the config values? |
|
That's plausible, but we'll have to make them default to |
msullivan
force-pushed
the
optional-tx-isolation-2
branch
2 times, most recently
from
213dc8a to
1ffc527
Compare
COMMENTS NEEDED: We may want to reconsider the interface the user uses to specify it! Currently it works by setting default_transaction_isolation to the enum value PreferRepeatableRead. If that is set, the parse and execute paths will strip it from the state that is sent, and then potentially inject RepeatableRead as the value when doing execute, if it is safe.
I am actually still -0 on this, though.
|
Alright I think this is done, now? |
Changes ======= * Enable reflecting of `ext` types. (by @vpetrovykh in 80a6b52) * Enable multiple modules for SQLModel reflection. (by @vpetrovykh in 8a7fdb5) * Update SQLModel generator. (by @vpetrovykh in 1d1c937) * Fix an issue with generating SQLModel with array props. (by @vpetrovykh in 2acffba) * Add encode and decode for array of array. (by @dnwpark in cc10463 for #594) * Improve nested array test skipping (by @elprans in 4dd19cb) * Fix server binary detection in WSL (by @elprans in 0d60662 for #601) * Drop Python 3.8 support (by @elprans in 1209adc for #600) * Fix reused SSLContext ALPN bug (by @fantix in 8874060 for #602) * Pin Django to ~5.1 (by @msullivan in dff941e for #610) * Make IsolationLevel enum values match the server names (by @msullivan in 7d2a401 for #611) * Make TransactionOptions default to optional (by @msullivan in 553e3ce for #612) * Implement PreferRepeatableRead, apply TransactionOptions to config state (by @msullivan in 46dae11 for #609) * Support PreferRepeatableRead on explicit transactions by retrying (by @msullivan in e1e25c0 for #616) * Make EnumValue support comparison to strings (by @msullivan in bb93ed7 for #615) * Update AI RAG response parsing. (by @dnwpark in 9060b04 for #618)
3 participants
COMMENTS NEEDED: We may want to reconsider the interface the user uses
to specify it!
Currently it works by setting default_transaction_isolation to the
enum value PreferRepeatableRead.
If that is set, the parse and execute paths will strip it from the
state that is sent, and then potentially inject RepeatableRead as the
value when doing execute, if it is safe.