{{ message }}
Repository navigation
fix(agent-playground): display error message for node failures with partial output - #3561
Open
mananjain04 wants to merge 13 commits into
Open
mananjain04 wants to merge 13 commits into
mananjain04 wants to merge 13 commits into
Conversation
…l error display with outputs
…node failures with partial output
…ero and partial output states
…t tokens and typography
…ror state in grid
…der error banner or error row
…camelCase and snake_case API fields
…ge support in NodeErrorAlert
…s running and settled node statuses
…ode execution failure
…il and NodeErrorAlert
github-actions
Bot
added
the
needs-admission
mananjain04
changed the title
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the bug where a node in Agent Playground that fails after producing partial output suppresses the error message. Decoupled error detection from output array length, rendering a styled NodeErrorAlert banner while preserving partial outputs in AG Grid.
Linked issues
Closes #2503
AI use
AI use: none
Type of change
E2E coverage
E2E: exempt (cosmetic)
1) What changes were done
A. Decouple error message check from output count
NodeOutputDetail.jsx, changedhasErrorMessagecheck fromoutputs.length === 0toBoolean(errorMessage)so that partial outputs don't suppress errors.NodeErrorAlertbanner above AG Grid when an error occurs during execution.B. Added NodeErrorAlert component
NodeErrorAlert.jsxwith themed styles, alert icon, and collapsible view for lengthy error strings or stack traces.2) Why the changes were done
3) Tests written + scenarios each covers
NodeOutputDetail.test.js— Regression test suite for node failure and error alert handlingdetects error message presence even when outputs array is not empty— ensures error flag is active with partial outputshandles nodes that fail with zero outputs by rendering error in grid row and alert— verifies zero output fallbackhandles successful nodes with outputs and no error— ensures no false error alertsverifies error banner visibility behavior across running and settled node statuses— verifies running state handlingextracts error message from various API field keys— verifies camelCase and snake_case API payload compatibility