{{ message }}
Adding a new function to Enum module (isDefined)#382
Merged
Conversation
Contributor
Author
Contributor
Author
|
Seems like it still fails... |
Contributor
|
Please update and try a new build. |
Contributor
Author
|
Woohoo!! |
Collaborator
|
@panesofglass It looks like it builds. Would it make sense to merge this and release a new version? |
gdziadkiewicz
approved these changes
Mar 10, 2020
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working with Enums in F#, I think it's interesting to have a function that checks if an Enum value is a valid Enum, specially for Flagged Enums. Searching I found this snippet (http://www.fssnip.net/4V/title/Check-if-value-is-a-valid-enum-or-flags-combination) and I think it would be interesting to be added in this library.
I added some tests using it.
Thank you