Add release NuGet publish from CI by gdziadkiewicz · Pull Request #199 · fsprojects/FSharpx.Collections · GitHub
Skip to content

Add release NuGet publish from CI#199

Merged
gdziadkiewicz merged 2 commits into
fsprojects:masterfrom
gdziadkiewicz:Update-nuget-secret
Nov 13, 2022
Merged

Add release NuGet publish from CI#199
gdziadkiewicz merged 2 commits into
fsprojects:masterfrom
gdziadkiewicz:Update-nuget-secret

Conversation

@gdziadkiewicz

Copy link
Copy Markdown
Collaborator

No description provided.

@sergey-tihon sergey-tihon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not an expert in GitHub Actions. I think it is easier to run it and check that it works as expected.

Comment thread .github/workflows/dotnet.yml Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be simplified as github.event.inputs.release != 'true' ?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it can! Thanks

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this call will execute all FAKE targets from the beginning and probably fail on CINuGet because we do not provide GITHUB_TOKEN.

You may want to merge "NuGet" ==> "PublishNuget" into one FAKE target and then execute with --signle-targe param, like dotnet fake run build.fsx -t "PublishNuget" --single-target

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that CINuGet only prepares the package while PublishCINuGet requires the GITHUB_TOKEN. From what I see Release does not depend on PublishCINuGet. We will see in a moment :)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ddin't know about --single-target - noted.

@gdziadkiewicz gdziadkiewicz marked this pull request as ready for review November 13, 2022 16:36
@gdziadkiewicz gdziadkiewicz merged commit d89288c into fsprojects:master Nov 13, 2022
@gdziadkiewicz gdziadkiewicz deleted the Update-nuget-secret branch November 13, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants