{{ message }}
Repository navigation
Minor perf opt - #417
Merged
Merged
Minor perf opt#417
Conversation
- isNull is inline also in FSharp.Core - Faster eqTypes - Lazy load of ILAssemblyRefs - Avoid looping 120 libraries through on most cases
Thorium
force-pushed
the
designtime-perf-opt
branch
from
May 10, 2025 14:32
44dec43 to
1f9af4a
Compare
Member
Author
There was a problem hiding this comment.
Pull Request Overview
This PR applies minor performance optimizations to the type provider code by reducing unnecessary computations and delaying resource-intensive operations until needed.
- Changed utility functions (isNull, isNil, isEmpty) to be inline.
- Introduced lazy initialization for ILAssemblyRefs to defer their construction.
- Modified ProvidedTypes lookup logic to short-circuit basic type translations while reusing the ProvidedTypeSymbol check.
Comments suppressed due to low confidence (1)
src/ProvidedTypes.fs:6256
- Ensure that the lazy initialization is thread-safe in contexts where ILAssemblyRefs may be accessed concurrently. If concurrent access is possible, consider specifying an explicit thread-safety mode or verifying that the default Lazy behavior meets the requirements.
let ilAssemblyRefs = lazy [ for i in 1 .. getNumRows ILTableNames.AssemblyRef do yield seekReadAssemblyRef i ]
Member
Author
The type ILModuleReader in ProvidedTypes.fs uses a lot of |
Member
This was referenced Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would love to have some benchmark tests for ProvidedTypes.fs but the issue is that it's mostly used by FSharp.Compiler via a heavy IDE, and current unit-tests are not covering the majority of the process, so I don't have any idea how that could be done. Right now the best way seems to be to attach a VS to VS and open some type-provider and see what is going on.