Confidence Score: 5/5

[Medium impact] The change appears safe to merge.

_{Reviews (3) · Last reviewed commit: "fix(stock): show unmatched scan in a mes..." · Reviewed by Greptile}

Auto-generated review.

Verdict: Approve

Reproduced on develop (console + browser): in the "Scan barcode for item" dialog of a draft Delivery Note, scanning an unknown serial (S999999) or a serial of another item cleared the input with no message and no count change. scan_barcode returns {} for both, and update_dialog_values had no else branch.

On the PR head both scans now show "Cannot find for Item " and call play_fail_sound, the value is HTML-escaped, and valid serials still count afterwards.

Nothing pushed.

Non-blocking:

• barcode_scanner.js:395 - one silent path is left: same item, but a barcode other than the dialog's (second barcode of the item, or the item barcode in a dialog opened from a serial) with no batch/serial. Out of scope for Barcode Scanner: "Scan barcode for item" dialog silently discards unknown or mismatched Serial Nos #61763; can be a follow-up.

Same silent path exists on version-15-hotfix and version-16-hotfix (identical update_dialog_values), so added both backport labels.

@Mergifyio queue

Merge Queue Status

• ✅ Entered queue — 2026-10-21 12:42 UTC · Rule: default · triggered by @mihir-kandoi with the @mergifyio queue command
• ❌ Checks failed (attempt 1/2) — 2026-10-21 12:46 UTC · on draft merge queue: checking #61734 + #61773 + #61765 + #61737 together on develop (f01723b) #61787
  • ❌ Python Unit Tests (3) (job log)
• ❌ Checks failed (attempt 2/2) — 2026-10-21 13:00 UTC · on draft merge queue: checking #61734 + #61773 + #61765 + #61737 together on develop (f01723b) #61788
  • ❌ Python Unit Tests (3) (job log)
• ✂️ Bisecting to identify the failing PR (round 1/2)
• ❌ Checks failed (attempt 1/2) — 2026-10-21 13:16 UTC · on draft merge queue: checking #61765 on develop (f01723b), stacked on #61734 and #61773 #61790
  • ❌ Patch Test (job log)
• ✅ Checks passed · on draft merge queue: checking #61773 + #61765 + #61737 together on develop (f01723b) #61798
• ✅ Merged — 2026-10-21 14:35 UTC · at e55270d5bf44af95c332e5295da6b4eaad182a8f · merge

This pull request spent 1 hour 53 minutes 22 seconds in the queue, including 1 hour 22 minutes 4 seconds running CI.