{{ message }}
Clarify getInputFromSessionKey missing-key exception #11377 - #11543
Open
AzazelSensei wants to merge 1 commit into
Open
Clarify getInputFromSessionKey missing-key exception #11377#11543AzazelSensei wants to merge 1 commit into
AzazelSensei wants to merge 1 commit into
Conversation
Frank!Doc made it sound like only FixedForwardPipe threw. Missing session key with no defaultValue always throws. Fixes frankframework#11377
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Frank!Doc for
getInputFromSessionKeysaid a missing session key only threw when the pipe was not a FixedForwardPipe. That reads like a class-name special case.InputOutputPipeProcessor.getInputFromthrows for any pipe when the key is missing and there is nodefaultValue. I rephrased the Javadoc to match that.Fixes #11377