{{ message }}
Repository navigation
[P8.6] E2B sandbox: remaining RALPH_DIR edge cases (symlink to outside, cwd /, outside-workspace mapping) #388
Description
Spun off from PR #387 (issue #383) during post-merge disposition.
Context
validate_e2b_sandbox_config (lib/sandbox_e2b.sh) now rejects a RALPH_DIR at the workspace root or outside the workspace for --sandbox e2b. Three shapes were left as Known Limitations in that PR; the GLM review on #387 confirmed the first two.
- Symlinked
RALPH_DIR. The check is lexical, like the rest of the control-dir handling. An in-workspaceRALPH_DIRthat is a symlink to a directory outside the workspace passes validation. What the upload, download and deletion guards then do with it has not been verified. - Working directory
/._e2b_control_dirstrips the workspace prefix with a"$base"/*match, which never matches when the base is/. An in-workspaceRALPH_DIRsuch as/.ralphstays absolute and is rejected as "outside the workspace". Fail-closed, and only reachable by running the loop from the filesystem root. - Outside-workspace
RALPH_DIRis unsupported for E2B. [P2.7] E2B sandbox: handle RALPH_DIR at the workspace root or outside the workspace #383 allowed either failing fast or mapping the control files to a fixed in-sandbox path; fix(sandbox): E2B fails fast on RALPH_DIR at the workspace root or outside it (#383) #387 took fail-fast. Nobody has asked for E2B with external control state.
Why it was not done in that PR
Out of scope per the PR body: #383's definition of done was met by failing fast, and none of these had a known user or a reproduced failure.
Definition of done
- Symlinked
RALPH_DIRunder--sandbox e2b: behavior verified with a test, and either supported or rejected at startup with a clear message - Decide whether the
/working-directory case is worth fixing; if so, an in-workspaceRALPH_DIRthere is accepted - Outside-workspace mapping: implement only if a real use case appears; otherwise close this item as not planned
Activity
github-actions commentedon Oct 10, 2026
Triage: bug (technical debt / follow-up)
Categorized as a bug — correctly already labeled
bugandlegacy. This is a legitimate follow-up tracking issue spun off from PR #387 / issue #383, capturing three remainingRALPH_DIRedge cases for--sandbox e2b. It is not a duplicate: the neighboring issue #389 covers a separate E2B upload-list defect (.ralphrclisted twice), not the control-dir validation gaps described here.No label changes needed. Assigning to @frankbria for disposition of the open Definition-of-Done items:
RALPH_DIR— the validation is lexical, so an in-workspace symlink pointing outside the workspace passes. Add a test and either support it or reject it at startup with a clear message./— currently fails closed (an in-workspaceRALPH_DIRlike/.ralphis rejected as "outside the workspace"); only reachable when running from the filesystem root. Decide whether it's worth fixing.Automated triage.