{{ message }}
Repository navigation
Conversation
Measures the byte[] GetByteRange on memory, range, composite (memory and temp-file children), even-length (memory and temp-file inner buffer), endian-swapped and temp-file buffers, for a 64-byte read and a 256 KB read. Related to fo-dicom#2122
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #2122. Adds a baseline benchmark for
IByteBuffer.GetByteRange, so the upcoming Span-based buffer changes can show before/after numbers.Checklist
Changes proposed in this pull request:
ByteBufferGetByteRangeBenchmark. It calls thebyte[]GetByteRangethroughIByteBufferonMemoryByteBuffer,RangeByteBuffer,CompositeByteBuffer(memory and temp-file children),EvenLengthBuffer(memory and temp-file inner buffer),EndianByteBuffer(big endian, 2-byte units) andTempFileBuffer.MemoryByteBufferis the baseline;[MemoryDiagnoser]is on.Results on development
.NET 10, AMD Ryzen 9 5900X.
EvenLengthOfTempFileallocates the whole 512 KB inner buffer even for a 64-byte read.