{{ message }}
Add support for incomplete types - #4383
Closed
localspook wants to merge 2 commits into
Closed
Conversation
vitaut
requested changes
Mar 29, 2025
vitaut
left a comment
vitaut
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR. Overall looks good but let's not introduce a new test binary just for this and instead add a test case to format-test (I don't think we need to test interaction with color).
Contributor
Author
vitaut
requested changes
Mar 31, 2025
vitaut
left a comment
vitaut
left a comment
Contributor
There was a problem hiding this comment.
Thinking more of it, it's quite convenient to inherit from view. I suggest keeping it by defaulting is_view to a SFINAE-friendly equivalent to is_base_of, something like:
struct view {};
template <typename T, typename Enable = void>
struct is_view : std::false_type {};
template <typename T>
struct is_view<
T, std::void_t<decltype(static_cast<view&>(std::declval<T&>()))>>
: std::true_type {};
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just requires replacing the
viewbase with anis_viewtype trait that can be queried on incomplete types.Fixes #3180.