{{ message }}
Repository navigation
Conversation
…equests Lets a client name the queue the run will be placed on so the server can write run artifacts into that queue's cluster-pool object store instead of the project/domain default pool. Mirrors SelectClusterRequest.queue_id (#8088). Assisted-by: Claude Code <noreply@anthropic.com> Signed-off-by: Sergey Vilgelm <sergey@union.ai>
The previous commit was generated with buf 1.73; CI runs 1.58, which orders source-code-info differently in the embedded descriptor set. Assisted-by: Claude Code <noreply@anthropic.com> Signed-off-by: Sergey Vilgelm <sergey@union.ai>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Related to #8088 (SelectCluster by
queue_id). Linear: RUN-70.Why are the changes needed?
A client that already knows which queue a run will be placed on has no way to say so when it uploads the run's inputs or requests an upload location. The server therefore writes those artifacts into the project/domain default cluster pool's bucket, which is the wrong bucket when the queue maps to a different pool. Server-side routing by queue already exists for
SelectCluster(#8088); this adds the same hint to the two upload RPCs for backends that are not routed throughSelectCluster.What changes were proposed in this pull request?
In
flyteidl2/dataproxy/dataproxy_service.proto:UploadInputsRequest: new optionalstring queue = 8. The name of the queue the run will be placed on, resolved in the run's project/domain scope likeRunSpec.queue. When set, inputs are written to that queue's cluster-pool object store; when empty, the project/domain default queue's pool is used.CreateUploadLocationRequest: new optionalstring queue = 10with the same semantics for the generated upload location.Single-cluster deployments may ignore the field. Generated Go, Python, Rust and TypeScript outputs are regenerated. No validation rules; purely additive and wire-compatible.
Consumers:
unionai/clouddataproxy (server side) andflyte-sdk(client side).How was this patch tested?
make buf-lint,buf-go,buf-python,buf-rust,buf-tsrun locally; only dataproxy outputs changed.go build ./...andgo vet ./gen/go/flyteidl2/dataproxy/...pass.Labels
Check all the applicable boxes