Update add to app android_view to api 35 by reidbaker · Pull Request #2368 · flutter/samples · GitHub
Skip to content

Update add to app android_view to api 35#2368

Merged
reidbaker merged 3 commits into
flutter:mainfrom
reidbaker:i152374-sample-projects-api-35-part-1
Jul 29, 2024
Merged

Update add to app android_view to api 35#2368
reidbaker merged 3 commits into
flutter:mainfrom
reidbaker:i152374-sample-projects-api-35-part-1

Conversation

@reidbaker

@reidbaker reidbaker commented Jul 26, 2024

Copy link
Copy Markdown
Contributor

Part 1/n flutter/flutter#152374

Pre-launch Checklist

  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I read the [Contributors Guide].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

@reidbaker reidbaker requested a review from gmackall July 26, 2024 16:05
@reidbaker reidbaker requested a review from gmackall July 26, 2024 16:40

@gmackall gmackall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still lgtm

@reidbaker reidbaker requested a review from ericwindmill July 26, 2024 16:46
@reidbaker

Copy link
Copy Markdown
Contributor Author

@reidbaker

Copy link
Copy Markdown
Contributor Author

Current theory: The failure might be flutter version dependent. I will check out the previous stable and see if I can reproduce.

@reidbaker

Copy link
Copy Markdown
Contributor Author

@reidbaker reidbaker merged commit f443fa6 into flutter:main Jul 29, 2024
@reidbaker reidbaker deleted the i152374-sample-projects-api-35-part-1 branch July 29, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants