Remove the accessibility evaluations feature flag - #192266
Conversation
Removes the `isAccessibilityEvaluationsEnabled` runtime flag and `enable-accessibility-evaluations` tool feature, as flutter#32057 is already fixed.
github-actions
Bot
added
a: tests
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the experimental 'accessibility_evaluations' feature flag and its associated checks, configurations, and tests across the Flutter framework and tools. The feedback suggests following through with the cleanup by refactoring or removing the duplicated '_isImportantForAccessibility' method in 'SemanticsController', which was previously marked for removal once this feature flag was enabled.
I am having trouble creating individual review comments. Click here to see my feedback.
packages/flutter_test/lib/src/controller.dart (340-341)
The removed comment indicated that _isImportantForAccessibility would be removed once the feature flag is turned on. Since the feature flag is now being removed, we should follow through with this cleanup. If the method is still needed by SemanticsController, consider refactoring it to a shared location (such as a property/helper on SemanticsNode or exporting it from _accessibility_evaluations.dart) to eliminate the duplication and the maintenance hazard mentioned in the remaining TODO.
2 participants
Removes the
isAccessibilityEvaluationsEnabledruntime flag andenable-accessibility-evaluationstool feature, as #32057 is already fixed by #181672, it now supports a11y evaluation not only on debug mode.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.