{{ message }}
[windows]: adjusts uniform buffers to hit hlsl optimization#188538
Open
gaaclarke wants to merge 6 commits into
Open
[windows]: adjusts uniform buffers to hit hlsl optimization#188538gaaclarke wants to merge 6 commits into
gaaclarke wants to merge 6 commits into
Conversation
…ove HLSL compilation performance.
github-actions
Bot
added
engine
Member
Author
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors several shaders and their corresponding host-side rendering code to move large arrays (such as colors, stop pairs, and kernel samples) into dedicated uniform blocks, preventing size and alignment issues on certain graphics platforms. Feedback recommends passing the temporary returned by GenerateBlurInfo directly to LerpHackKernelSamples to enable copy elision and avoid copying a large struct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue #188348
This removes the following class of HLSL warnings:
By putting large uniform arrays into their own uniform buffer the HLSL compiler in ANGLE is able to optimize the compilation using a StructuredBuffer. This removes the warning about long compilation time.
testing: refactor, no logical change
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.