[dev, bots, examples] rename local functions with `_`s by pq · Pull Request #102703 · flutter/flutter · GitHub
Skip to content

[dev, bots, examples] rename local functions with _s - #102703

Merged
fluttergithubbot merged 1 commit into
flutter:masterfrom
pq:non_constant_identifier_names_dev
Apr 28, 2022
Merged

[dev, bots, examples] rename local functions with _s#102703
fluttergithubbot merged 1 commit into
flutter:masterfrom
pq:non_constant_identifier_names_dev

Conversation

@pq

@pq pq commented Apr 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

These will be flagged by the next linter release which updates non_constant_identifier_names to flag local functions.

See also:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@pq
rename local functions with _s
358cb61 
These will be flagged by the next linter release which updates `non_constant_identifier_names` to flag local functions.
@flutter-dashboard flutter-dashboard Bot added a: animation Animation APIs d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages c: contributor-productivity Team-specific productivity, code health, technical debt. labels Apr 28, 2022
@pq
pq requested a review from goderbauer April 28, 2022 00:58
goderbauer
goderbauer approved these changes Apr 28, 2022
View reviewed changes

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot

fluttergithubbot commented Apr 28, 2022

Copy link
Copy Markdown
Contributor

@fluttergithubbot
fluttergithubbot merged commit 80849ad into flutter:master Apr 28, 2022
@pq
pq deleted the non_constant_identifier_names_dev branch April 28, 2022 17:50
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
80849ad [dev, bots, examples] rename local functions with _s (flutt…
b8361f5 
…er/flutter#102703)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2022
@engine-flutter-autoroll
80849ad [dev, bots, examples] rename local functions with _s (flutt…
34ee9e7 
…er/flutter#102703)
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@pq @egramond
[dev, bots, examples] rename local functions with _s (flutter#102703)
214247d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: animation Animation APIs c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pq @fluttergithubbot @goderbauer