Regex fixups by jnyrup · Pull Request #3034 · fluentassertions/fluentassertions · GitHub
Skip to content

Regex fixups#3034

Merged
jnyrup merged 2 commits into
fluentassertions:mainfrom
jnyrup:jn/regex_fixups
Feb 24, 2025
Merged

Regex fixups#3034
jnyrup merged 2 commits into
fluentassertions:mainfrom
jnyrup:jn/regex_fixups

Conversation

@jnyrup

@jnyrup jnyrup commented Feb 23, 2025

Copy link
Copy Markdown
Member
  1. Adjust incorrect explaining comment about regex.

  2. Remove | from regex character classes

| means the literal | and not alternation, i.e. [a|b] means "a, | or b".
On the other hand in groups (a|b) means "either a or b"

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

`|` means the literal `|` and not alternation.
I.e. `[a|b]` means "`a`, `|` or `b`".
On the other hand in groups `(a|b)` means "either `a` or `b`"
@jnyrup jnyrup changed the title Jn/regex fixups Regex fixups Feb 23, 2025
@github-actions

Copy link
Copy Markdown

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 13486471809

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.43%

Totals Coverage Status
Change from base Build 13486430615: 0.0%
Covered Lines: 12326
Relevant Lines: 12510

💛 - Coveralls

@dennisdoomen dennisdoomen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing my mistakes 😜

@jnyrup jnyrup merged commit 6751587 into fluentassertions:main Feb 24, 2025
@jnyrup jnyrup deleted the jn/regex_fixups branch February 24, 2025 11:30
@dennisdoomen dennisdoomen added this to the 8.2.0 milestone Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants