Bump PolySharp from 1.14.1 to 1.15.0 by dependabot[bot] · Pull Request #2884 · fluentassertions/fluentassertions · GitHub
Skip to content

Bump PolySharp from 1.14.1 to 1.15.0#2884

Merged
dennisdoomen merged 1 commit into
developfrom
dependabot/nuget/PolySharp-1.15.0
Dec 17, 2024
Merged

Bump PolySharp from 1.14.1 to 1.15.0#2884
dennisdoomen merged 1 commit into
developfrom
dependabot/nuget/PolySharp-1.15.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Dec 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Bumps PolySharp from 1.14.1 to 1.15.0.

Release notes

Sourced from PolySharp's releases.

1.15.0

This PolySharp release includes C# 13 support.

🪄 Polyfills

🔧 Other changes

New Contributors

Commits
  • 02753db Merge pull request #114 from Sergio0694/dev/constant-expected-attribute
  • cd55412 Add tests for '[ConstantExpected]' attribute
  • 8ed69f9 Update 'README.md' files
  • b100d4b Add 'ConstantExpectedAttribute' type
  • 06e5008 Merge pull request #108 from teo-tsirpanis/net9
  • 81cedeb Fix a typo in CONTRIBUTING.md
  • 92b7b24 Use .NET 9 SDK, update unit tests
  • d9e4541 Update README.md files
  • b71f56f Adapt the attributes to the codebase's standards.
  • 32ac9c8 Copy .NET 9 attribute sources from dotnet/runtime.
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot Bot added .NET Pull requests that update .net code dependencies Pull requests that update a dependency file labels Dec 16, 2024
@github-actions

github-actions Bot commented Dec 16, 2024 •
edited
Loading

Copy link
Copy Markdown

@coveralls

coveralls commented Dec 16, 2024 •
edited
Loading

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 12376681718

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.398%
Totals Coverage Status
Change from base Build 12376617590: 0.0%
Covered Lines: 12373
Relevant Lines: 12562
💛 - Coveralls

@dennisdoomen

dennisdoomen commented Dec 16, 2024

Copy link
Copy Markdown
Member

@dependabot rebase

@dependabot dependabot Bot force-pushed the dependabot/nuget/PolySharp-1.15.0 branch from 4a81f11 to b04920e Compare December 16, 2024 16:58
@dennisdoomen

dennisdoomen commented Dec 16, 2024

Copy link
Copy Markdown
Member

@dependabot rebase

@dependabot dependabot Bot force-pushed the dependabot/nuget/PolySharp-1.15.0 branch from b04920e to dcab75c Compare December 16, 2024 19:26
@jnyrup

jnyrup commented Dec 16, 2024

Copy link
Copy Markdown
Member

Interesting, the canceled Qodana run threw a Dictionary exception

@dennisdoomen

dennisdoomen commented Dec 17, 2024

Copy link
Copy Markdown
Member

Yeah, I wonder now if this is a Qodana issue or a Polysharp issue. I'll try with the previous version of Qodana first.

@dennisdoomen

dennisdoomen commented Dec 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

I've just tried running a PR with the previous version of Qodana and I see the same behavior. I'm going to report an issue.

Sergio0694/PolySharp#116

@jnyrup

jnyrup commented Dec 17, 2024

Copy link
Copy Markdown
Member

Looking at the changes in PolySharp, I think the problem is in in Qodana.
To test with an older version of Qodana, wouldn't we need to merge the revert the Qodana upgrade and then rebase this PR?

I also notice that it varies which polyfilled type from PolySharp is mentioned in the stack exceptions and that none of them changed in 1.15.0

Message = “An item with the same key has already been added. Key: PolySharp.SourceGenerators\PolySharp.SourceGenerators.PolyfillsGenerator\System.Diagnostics.CodeAnalysis.UnscopedRefAttribute.g.cs”

https://github.com/fluentassertions/fluentassertions/actions/runs/12359824708/job/34493370009#step:3:140

Message = “An item with the same key has already been added. Key: PolySharp.SourceGenerators\PolySharp.SourceGenerators.PolyfillsGenerator\System.Diagnostics.CodeAnalysis.SetsRequiredMembersAttribute.g.cs”

https://github.com/fluentassertions/fluentassertions/actions/runs/12357487327/job/34485851957#step:3:145

@dennisdoomen

dennisdoomen commented Dec 17, 2024

Copy link
Copy Markdown
Member

To test with an older version of Qodana, wouldn't we need to merge the revert the Qodana upgrade and then rebase this PR?

Good point.

@dennisdoomen

dennisdoomen commented Dec 17, 2024

Copy link
Copy Markdown
Member

The recommendation from JetBrains is to switch back to an earlier version of the Qodana plug-in until they've analyzed the problem.

@dennisdoomen dennisdoomen mentioned this pull request Dec 17, 2024
Merged
@dennisdoomen

dennisdoomen commented Dec 17, 2024

Copy link
Copy Markdown
Member

@dependabot rebase

@dependabot
Bump PolySharp from 1.14.1 to 1.15.0
a78d464 
Bumps [PolySharp](https://github.com/Sergio0694/PolySharp) from 1.14.1 to 1.15.0.
- [Release notes](https://github.com/Sergio0694/PolySharp/releases)
- [Commits](Sergio0694/PolySharp@1.14.1...1.15.0)

---
updated-dependencies:
- dependency-name: PolySharp
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/nuget/PolySharp-1.15.0 branch from dcab75c to a78d464 Compare December 17, 2024 15:57
@github-actions

github-actions Bot commented Dec 17, 2024

Copy link
Copy Markdown

@dennisdoomen dennisdoomen merged commit 6ac14f2 into develop Dec 17, 2024
@dennisdoomen dennisdoomen deleted the dependabot/nuget/PolySharp-1.15.0 branch December 17, 2024 16:52
This was referenced Jul 21, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jun 16, 2026
Merged
Merged
Closed
Open
Closed
Closed
Closed
Open
Closed
Closed
Open
Closed
Closed
Open
This was referenced Jun 23, 2026
Open
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Open
This was referenced Jul 1, 2026
Open
Open
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file .NET Pull requests that update .net code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coveralls @dennisdoomen @jnyrup