Fixed a regression in which CompleteWithinAsync treated a canceled task as an exception by dennisdoomen · Pull Request #2853 · fluentassertions/fluentassertions · GitHub
Skip to content

Fixed a regression in which CompleteWithinAsync treated a canceled task as an exception#2853

Merged
dennisdoomen merged 1 commit into
fluentassertions:support-7.0from
dennisdoomen:fix-canceled-task
Feb 11, 2025
Merged

Fixed a regression in which CompleteWithinAsync treated a canceled task as an exception#2853
dennisdoomen merged 1 commit into
fluentassertions:support-7.0from
dennisdoomen:fix-canceled-task

Conversation

@dennisdoomen

@dennisdoomen dennisdoomen commented Nov 28, 2024

Copy link
Copy Markdown
Member

Closes #2833

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@coveralls

coveralls commented Nov 28, 2024 •
edited
Loading

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Nov 28, 2024 •
edited
Loading

Copy link
Copy Markdown

@dennisdoomen dennisdoomen requested a review from jnyrup November 28, 2024 18:55
jnyrup
jnyrup reviewed Nov 29, 2024
View reviewed changes
Comment thread Tests/FluentAssertions.Specs/Specialized/TaskAssertionSpecs.cs Outdated
Comment thread Src/FluentAssertions/Specialized/AsyncFunctionAssertions.cs Outdated
Comment thread Tests/FluentAssertions.Specs/Specialized/TaskAssertionSpecs.cs Outdated
jnyrup
jnyrup reviewed Nov 30, 2024
View reviewed changes
Comment thread Src/FluentAssertions/Specialized/GenericAsyncFunctionAssertions.cs
@dennisdoomen dennisdoomen requested review from jnyrup and removed request for jnyrup December 15, 2024 12:47
jnyrup
jnyrup reviewed Dec 17, 2024
View reviewed changes
Comment thread Tests/FluentAssertions.Specs/Specialized/TaskCompletionSourceAssertionSpecs.cs
Comment thread Tests/FluentAssertions.Specs/Specialized/TaskCompletionSourceAssertionSpecs.cs
@jnyrup jnyrup mentioned this pull request Dec 19, 2024
Merged
7 tasks
@jnyrup jnyrup changed the base branch from main to support-7.0 January 19, 2025 20:07
@jnyrup jnyrup changed the base branch from support-7.0 to main January 19, 2025 20:08
@jnyrup jnyrup changed the base branch from main to support-7.0 January 19, 2025 20:15
@jnyrup jnyrup force-pushed the fix-canceled-task branch 2 times, most recently from 5c823fa to 6e030f1 Compare January 19, 2025 20:18
@dennisdoomen dennisdoomen deleted the fix-canceled-task branch January 20, 2025 19:33
@dennisdoomen dennisdoomen restored the fix-canceled-task branch February 1, 2025 16:58
@dennisdoomen dennisdoomen reopened this Feb 1, 2025
@jnyrup jnyrup added this to the 7.2.0 milestone Feb 10, 2025
@dennisdoomen dennisdoomen merged commit 3dd8243 into fluentassertions:support-7.0 Feb 11, 2025
@dennisdoomen dennisdoomen deleted the fix-canceled-task branch February 16, 2025 17:06
This was referenced Jun 15, 2026
Closed
Closed
Merged
Closed
Closed
Closed
Merged
Open
Closed
Closed
Open
Closed
Closed
Closed
Open
This was referenced Jun 24, 2026
Closed
Open
Closed
Open
Open
Open
Open
Open
Open
Open
This was referenced Jul 1, 2026
Open
Open
Open
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnyrup jnyrup jnyrup approved these changes

Assignees

@jnyrup jnyrup

Labels

bug

Projects

None yet

Milestone

7.2.0

Development

Successfully merging this pull request may close these issues.

CompleteWithinAsync fails for canceled Tasks

3 participants

@dennisdoomen @coveralls @jnyrup