{{ message }}
Various naming improvements #2745
Merged
dennisdoomen merged 6 commits intoAug 28, 2024
Merged
Conversation
dennisdoomen
force-pushed
the
refactor/small-improvements
branch
from
47c6269 to
63546c3
Compare
dennisdoomen
force-pushed
the
refactor/small-improvements
branch
from
63546c3 to
4236ef1
Compare
Pull Request Test Coverage Report for Build 10590963523Details
💛 - Coveralls |
ITaluone
reviewed
Aug 27, 2024
jnyrup
approved these changes
Aug 27, 2024
jnyrup
left a comment
jnyrup
left a comment
Member
There was a problem hiding this comment.
We should document all breaking changes.
dennisdoomen
force-pushed
the
refactor/small-improvements
branch
from
4236ef1 to
ff5c697
Compare
The name of EquivalencyResult.AssertionCompleted wasn't clear what it tried to accomplish. This has been improved. Also improved the interface that equivalency steps can use for recursive assertions.
dennisdoomen
force-pushed
the
refactor/small-improvements
branch
from
ff5c697 to
981a4bb
Compare
This was referenced Jul 21, 2025
This was referenced Jun 21, 2026
Closed
This was referenced Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #2539
EquivalencyResult.AssertionCompletedwasn't clear what it tried to accomplish. This has been improved. Also renamed the interface that equivalency steps can use for recursive assertions.Note Can be reviewed commit-by-commit