{{ message }}
BeEmpty() materializes IEnumerable<T> only once, even on failure#2530
Merged
Conversation
dennisdoomen
approved these changes
Jan 1, 2024
Pull Request Test Coverage Report for Build 7416242537Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
jnyrup
approved these changes
Jan 4, 2024
Member
|
A note: This partly reverts #227, but I'm fine with the change here. |
Contributor
Author
Done |
- Make BeEmpty() materialize only the first item, as no further processing is needed for validation - The error message now mentions "but found at least 1 item" and outputs the said item
Member
|
Aren't we missing a test for |
Contributor
|
@louis-z Did you intentionally left this out from the release notes? IMHO this is worth to be added there? 🤔 |
Member
|
Fair point. |
jnyrup
pushed a commit
to jnyrup/fluentassertions
that referenced
this pull request
Jul 14, 2024
…entassertions#2530) * BeEmpty() materializes IEnumerable<T> only once, even on failure - Make BeEmpty() materialize only the first item, as no further processing is needed for validation - The error message now mentions "but found at least 1 item" and outputs the said item * Tweak error message & fix tests * Make similar changes for BeNullOrEmpty * Add test, as per request
jnyrup
pushed a commit
to jnyrup/fluentassertions
that referenced
this pull request
Jul 14, 2024
…entassertions#2530) * BeEmpty() materializes IEnumerable<T> only once, even on failure - Make BeEmpty() materialize only the first item, as no further processing is needed for validation - The error message now mentions "but found at least 1 item" and outputs the said item * Tweak error message & fix tests * Make similar changes for BeNullOrEmpty * Add test, as per request
jnyrup
pushed a commit
to jnyrup/fluentassertions
that referenced
this pull request
Jul 14, 2024
…entassertions#2530) * BeEmpty() materializes IEnumerable<T> only once, even on failure - Make BeEmpty() materialize only the first item, as no further processing is needed for validation - The error message now mentions "but found at least 1 item" and outputs the said item * Tweak error message & fix tests * Make similar changes for BeNullOrEmpty * Add test, as per request
jnyrup
pushed a commit
to jnyrup/fluentassertions
that referenced
this pull request
Aug 18, 2024
…entassertions#2530) * BeEmpty() materializes IEnumerable<T> only once, even on failure - Make BeEmpty() materialize only the first item, as no further processing is needed for validation - The error message now mentions "but found at least 1 item" and outputs the said item * Tweak error message & fix tests * Make similar changes for BeNullOrEmpty * Add test, as per request
jnyrup
pushed a commit
to jnyrup/fluentassertions
that referenced
this pull request
Aug 18, 2024
…entassertions#2530) * BeEmpty() materializes IEnumerable<T> only once, even on failure - Make BeEmpty() materialize only the first item, as no further processing is needed for validation - The error message now mentions "but found at least 1 item" and outputs the said item * Tweak error message & fix tests * Make similar changes for BeNullOrEmpty * Add test, as per request
jnyrup
pushed a commit
to jnyrup/fluentassertions
that referenced
this pull request
Aug 24, 2024
…entassertions#2530) * BeEmpty() materializes IEnumerable<T> only once, even on failure - Make BeEmpty() materialize only the first item, as no further processing is needed for validation - The error message now mentions "but found at least 1 item" and outputs the said item * Tweak error message & fix tests * Make similar changes for BeNullOrEmpty * Add test, as per request
jnyrup
pushed a commit
that referenced
this pull request
Sep 9, 2024
* BeEmpty() materializes IEnumerable<T> only once, even on failure - Make BeEmpty() materialize only the first item, as no further processing is needed for validation - The error message now mentions "but found at least 1 item" and outputs the said item * Tweak error message & fix tests * Make similar changes for BeNullOrEmpty * Add test, as per request
This was referenced Jun 13, 2026
Merged
This was referenced Jun 21, 2026
Closed
This was referenced Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2490
IMPORTANT
./build.sh --target spellcheckor.\build.ps1 --target spellcheckbefore pushing and check the good outcome