Add support for NUnit4 by vbreuss · Pull Request #2483 · fluentassertions/fluentassertions · GitHub
Skip to content

Add support for NUnit4#2483

Merged
jnyrup merged 6 commits into
fluentassertions:developfrom
vbreuss:topic/support-nunit4
Nov 30, 2023
Merged

Add support for NUnit4#2483
jnyrup merged 6 commits into
fluentassertions:developfrom
vbreuss:topic/support-nunit4

Conversation

@vbreuss

@vbreuss vbreuss commented Nov 27, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add FrameworkSpecs for NUnit4 and mention support in documentation and package information.

Fixes #2482

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@github-actions

github-actions Bot commented Nov 27, 2023

Copy link
Copy Markdown

@coveralls

coveralls commented Nov 27, 2023 •
edited
Loading

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 7016904197

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.475%
Totals Coverage Status
Change from base Build 6941628243: 0.0%
Covered Lines: 11742
Relevant Lines: 11926
💛 - Coveralls

@vbreuss vbreuss marked this pull request as ready for review November 27, 2023 13:52
@dennisdoomen

dennisdoomen commented Nov 28, 2023

Copy link
Copy Markdown
Member

Since it seems to contain some breaking changes, supporting both Nunit 3 and 4 makes sense to me.

dennisdoomen
dennisdoomen reviewed Nov 28, 2023
View reviewed changes
Comment thread Tests/TestFrameworks/NUnit4.Specs/FrameworkSpecs.cs Outdated
Comment thread Tests/TestFrameworks/NUnit4.Specs/FrameworkSpecs.cs Outdated
Exception exception = act.Should().Throw<Exception>().Which;
exception.GetType()
.FullName.Should()
.ContainEquivalentOf("NUnit.Framework.AssertionException");

@dennisdoomen dennisdoomen Nov 28, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Are you sure this is the right one? I was also expecting a different version of the NUnitTestFramework type. Or are the exception types the same?

@jnyrup jnyrup Nov 28, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our current NUnitTestFramework also matches NUnit4, so no changes are needed on our side.

NUnit.Framework.AssertionException

image

@vbreuss vbreuss Nov 28, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Test adapter also remained unchanged, according to the release notes:
image

@jnyrup

jnyrup commented Nov 28, 2023

Copy link
Copy Markdown
Member

NUnit4 needs to added here

fluentassertions/Build/Build.cs

Lines 275 to 281 in 29e9699

var projects = new[]
{
Solution.TestFrameworks.MSpec_Specs,
Solution.TestFrameworks.MSTestV2_Specs,
Solution.TestFrameworks.NUnit3_Specs,
Solution.TestFrameworks.XUnit2_Specs
};

@jnyrup

jnyrup commented Nov 28, 2023

Copy link
Copy Markdown
Member

@jnyrup jnyrup merged commit 2f56211 into fluentassertions:develop Nov 30, 2023
This was referenced Jul 21, 2025
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
This was referenced Jun 18, 2026
Open
Closed
Open
Closed
Closed
Open
Open
Closed
Closed
Open
Closed
Open
Closed
Open
Open
Open
This was referenced Jun 27, 2026
Merged
Open
Open
Open
Merged
Open
Open
Open
Closed
Closed
Merged
Open
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes
@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for NUnit4

4 participants

@vbreuss @coveralls @dennisdoomen @jnyrup